Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Side by Side Diff: media/base/pipeline.cc

Issue 23702007: Render inband text tracks in the media pipeline (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: incorporate aaron's comments (10/12) Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "media/base/pipeline.h" 5 #include "media/base/pipeline.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/callback.h" 10 #include "base/callback.h"
11 #include "base/callback_helpers.h" 11 #include "base/callback_helpers.h"
12 #include "base/compiler_specific.h" 12 #include "base/compiler_specific.h"
13 #include "base/message_loop/message_loop.h" 13 #include "base/message_loop/message_loop.h"
14 #include "base/metrics/histogram.h" 14 #include "base/metrics/histogram.h"
15 #include "base/stl_util.h" 15 #include "base/stl_util.h"
16 #include "base/strings/string_number_conversions.h" 16 #include "base/strings/string_number_conversions.h"
17 #include "base/strings/string_util.h" 17 #include "base/strings/string_util.h"
18 #include "base/synchronization/condition_variable.h" 18 #include "base/synchronization/condition_variable.h"
19 #include "media/base/audio_decoder.h" 19 #include "media/base/audio_decoder.h"
20 #include "media/base/audio_renderer.h" 20 #include "media/base/audio_renderer.h"
21 #include "media/base/clock.h" 21 #include "media/base/clock.h"
22 #include "media/base/filter_collection.h" 22 #include "media/base/filter_collection.h"
23 #include "media/base/media_log.h" 23 #include "media/base/media_log.h"
24 #include "media/base/text_renderer.h"
24 #include "media/base/video_decoder.h" 25 #include "media/base/video_decoder.h"
25 #include "media/base/video_decoder_config.h" 26 #include "media/base/video_decoder_config.h"
26 #include "media/base/video_renderer.h" 27 #include "media/base/video_renderer.h"
27 28
28 using base::TimeDelta; 29 using base::TimeDelta;
29 30
30 namespace media { 31 namespace media {
31 32
32 Pipeline::Pipeline(const scoped_refptr<base::MessageLoopProxy>& message_loop, 33 Pipeline::Pipeline(const scoped_refptr<base::MessageLoopProxy>& message_loop,
33 MediaLog* media_log) 34 MediaLog* media_log)
34 : message_loop_(message_loop), 35 : message_loop_(message_loop),
35 media_log_(media_log), 36 media_log_(media_log),
36 running_(false), 37 running_(false),
37 did_loading_progress_(false), 38 did_loading_progress_(false),
38 total_bytes_(0), 39 total_bytes_(0),
39 natural_size_(0, 0), 40 natural_size_(0, 0),
40 volume_(1.0f), 41 volume_(1.0f),
41 playback_rate_(0.0f), 42 playback_rate_(0.0f),
42 clock_(new Clock(&default_tick_clock_)), 43 clock_(new Clock(&default_tick_clock_)),
43 waiting_for_clock_update_(false), 44 waiting_for_clock_update_(false),
44 status_(PIPELINE_OK), 45 status_(PIPELINE_OK),
45 has_audio_(false), 46 has_audio_(false),
46 has_video_(false), 47 has_video_(false),
47 state_(kCreated), 48 state_(kCreated),
48 audio_ended_(false), 49 audio_ended_(false),
49 video_ended_(false), 50 video_ended_(false),
51 text_ended_(false),
50 audio_disabled_(false), 52 audio_disabled_(false),
51 demuxer_(NULL), 53 demuxer_(NULL),
52 creation_time_(default_tick_clock_.NowTicks()) { 54 creation_time_(default_tick_clock_.NowTicks()) {
53 media_log_->AddEvent(media_log_->CreatePipelineStateChangedEvent(kCreated)); 55 media_log_->AddEvent(media_log_->CreatePipelineStateChangedEvent(kCreated));
54 media_log_->AddEvent( 56 media_log_->AddEvent(
55 media_log_->CreateEvent(MediaLogEvent::PIPELINE_CREATED)); 57 media_log_->CreateEvent(MediaLogEvent::PIPELINE_CREATED));
56 } 58 }
57 59
58 Pipeline::~Pipeline() { 60 Pipeline::~Pipeline() {
59 DCHECK(thread_checker_.CalledOnValidThread()) 61 DCHECK(thread_checker_.CalledOnValidThread())
(...skipping 226 matching lines...) Expand 10 before | Expand all | Expand 10 after
286 break; 288 break;
287 } 289 }
288 NOTREACHED() << "State has no transition: " << state_; 290 NOTREACHED() << "State has no transition: " << state_;
289 return state_; 291 return state_;
290 } 292 }
291 293
292 void Pipeline::OnDemuxerError(PipelineStatus error) { 294 void Pipeline::OnDemuxerError(PipelineStatus error) {
293 SetError(error); 295 SetError(error);
294 } 296 }
295 297
298 void Pipeline::AddTextStream(DemuxerStream* text_stream,
299 TextKind kind,
300 const std::string& label,
301 const std::string& language) {
302 base::AutoLock auto_lock(lock_);
303 message_loop_->PostTask(FROM_HERE, base::Bind(
304 &Pipeline::AddTextStreamTask, base::Unretained(this),
305 text_stream, kind, label, language));
306 }
307
296 void Pipeline::SetError(PipelineStatus error) { 308 void Pipeline::SetError(PipelineStatus error) {
297 DCHECK(IsRunning()); 309 DCHECK(IsRunning());
298 DCHECK_NE(PIPELINE_OK, error); 310 DCHECK_NE(PIPELINE_OK, error);
299 VLOG(1) << "Media pipeline error: " << error; 311 VLOG(1) << "Media pipeline error: " << error;
300 312
301 message_loop_->PostTask(FROM_HERE, base::Bind( 313 message_loop_->PostTask(FROM_HERE, base::Bind(
302 &Pipeline::ErrorChangedTask, base::Unretained(this), error)); 314 &Pipeline::ErrorChangedTask, base::Unretained(this), error));
303 315
304 media_log_->AddEvent(media_log_->CreatePipelineErrorEvent(error)); 316 media_log_->AddEvent(media_log_->CreatePipelineErrorEvent(error));
305 } 317 }
(...skipping 224 matching lines...) Expand 10 before | Expand all | Expand 10 after
530 542
531 // Pause. 543 // Pause.
532 if (audio_renderer_) { 544 if (audio_renderer_) {
533 bound_fns.Push(base::Bind( 545 bound_fns.Push(base::Bind(
534 &AudioRenderer::Pause, base::Unretained(audio_renderer_.get()))); 546 &AudioRenderer::Pause, base::Unretained(audio_renderer_.get())));
535 } 547 }
536 if (video_renderer_) { 548 if (video_renderer_) {
537 bound_fns.Push(base::Bind( 549 bound_fns.Push(base::Bind(
538 &VideoRenderer::Pause, base::Unretained(video_renderer_.get()))); 550 &VideoRenderer::Pause, base::Unretained(video_renderer_.get())));
539 } 551 }
552 if (text_renderer_) {
553 bound_fns.Push(base::Bind(
554 &TextRenderer::Pause, base::Unretained(text_renderer_.get())));
555 }
540 556
541 // Flush. 557 // Flush.
542 if (audio_renderer_) { 558 if (audio_renderer_) {
543 bound_fns.Push(base::Bind( 559 bound_fns.Push(base::Bind(
544 &AudioRenderer::Flush, base::Unretained(audio_renderer_.get()))); 560 &AudioRenderer::Flush, base::Unretained(audio_renderer_.get())));
545 } 561 }
546 if (video_renderer_) { 562 if (video_renderer_) {
547 bound_fns.Push(base::Bind( 563 bound_fns.Push(base::Bind(
548 &VideoRenderer::Flush, base::Unretained(video_renderer_.get()))); 564 &VideoRenderer::Flush, base::Unretained(video_renderer_.get())));
549 } 565 }
566 if (text_renderer_) {
567 bound_fns.Push(base::Bind(
568 &TextRenderer::Flush, base::Unretained(text_renderer_.get())));
569 }
550 570
551 // Seek demuxer. 571 // Seek demuxer.
552 bound_fns.Push(base::Bind( 572 bound_fns.Push(base::Bind(
553 &Demuxer::Seek, base::Unretained(demuxer_), seek_timestamp)); 573 &Demuxer::Seek, base::Unretained(demuxer_), seek_timestamp));
554 574
555 // Preroll renderers. 575 // Preroll renderers.
556 if (audio_renderer_) { 576 if (audio_renderer_) {
557 bound_fns.Push(base::Bind( 577 bound_fns.Push(base::Bind(
558 &AudioRenderer::Preroll, base::Unretained(audio_renderer_.get()), 578 &AudioRenderer::Preroll, base::Unretained(audio_renderer_.get()),
559 seek_timestamp)); 579 seek_timestamp));
(...skipping 19 matching lines...) Expand all
579 if (audio_renderer_) { 599 if (audio_renderer_) {
580 bound_fns.Push(base::Bind( 600 bound_fns.Push(base::Bind(
581 &AudioRenderer::Play, base::Unretained(audio_renderer_.get()))); 601 &AudioRenderer::Play, base::Unretained(audio_renderer_.get())));
582 } 602 }
583 603
584 if (video_renderer_) { 604 if (video_renderer_) {
585 bound_fns.Push(base::Bind( 605 bound_fns.Push(base::Bind(
586 &VideoRenderer::Play, base::Unretained(video_renderer_.get()))); 606 &VideoRenderer::Play, base::Unretained(video_renderer_.get())));
587 } 607 }
588 608
609 if (text_renderer_) {
610 bound_fns.Push(base::Bind(
611 &TextRenderer::Play, base::Unretained(text_renderer_.get())));
612 }
613
589 pending_callbacks_ = SerialRunner::Run(bound_fns, done_cb); 614 pending_callbacks_ = SerialRunner::Run(bound_fns, done_cb);
590 } 615 }
591 616
592 void Pipeline::DoStop(const PipelineStatusCB& done_cb) { 617 void Pipeline::DoStop(const PipelineStatusCB& done_cb) {
593 DCHECK(message_loop_->BelongsToCurrentThread()); 618 DCHECK(message_loop_->BelongsToCurrentThread());
594 DCHECK(!pending_callbacks_.get()); 619 DCHECK(!pending_callbacks_.get());
595 SerialRunner::Queue bound_fns; 620 SerialRunner::Queue bound_fns;
596 621
597 if (demuxer_) { 622 if (demuxer_) {
598 bound_fns.Push(base::Bind( 623 bound_fns.Push(base::Bind(
599 &Demuxer::Stop, base::Unretained(demuxer_))); 624 &Demuxer::Stop, base::Unretained(demuxer_)));
600 } 625 }
601 626
602 if (audio_renderer_) { 627 if (audio_renderer_) {
603 bound_fns.Push(base::Bind( 628 bound_fns.Push(base::Bind(
604 &AudioRenderer::Stop, base::Unretained(audio_renderer_.get()))); 629 &AudioRenderer::Stop, base::Unretained(audio_renderer_.get())));
605 } 630 }
606 631
607 if (video_renderer_) { 632 if (video_renderer_) {
608 bound_fns.Push(base::Bind( 633 bound_fns.Push(base::Bind(
609 &VideoRenderer::Stop, base::Unretained(video_renderer_.get()))); 634 &VideoRenderer::Stop, base::Unretained(video_renderer_.get())));
610 } 635 }
611 636
637 if (text_renderer_) {
638 bound_fns.Push(base::Bind(
639 &TextRenderer::Stop, base::Unretained(text_renderer_.get())));
640 }
641
612 pending_callbacks_ = SerialRunner::Run(bound_fns, done_cb); 642 pending_callbacks_ = SerialRunner::Run(bound_fns, done_cb);
613 } 643 }
614 644
615 void Pipeline::OnStopCompleted(PipelineStatus status) { 645 void Pipeline::OnStopCompleted(PipelineStatus status) {
616 DCHECK(message_loop_->BelongsToCurrentThread()); 646 DCHECK(message_loop_->BelongsToCurrentThread());
617 DCHECK_EQ(state_, kStopping); 647 DCHECK_EQ(state_, kStopping);
618 { 648 {
619 base::AutoLock l(lock_); 649 base::AutoLock l(lock_);
620 running_ = false; 650 running_ = false;
621 } 651 }
622 652
623 SetState(kStopped); 653 SetState(kStopped);
624 pending_callbacks_.reset(); 654 pending_callbacks_.reset();
625 filter_collection_.reset(); 655 filter_collection_.reset();
626 audio_renderer_.reset(); 656 audio_renderer_.reset();
627 video_renderer_.reset(); 657 video_renderer_.reset();
658 text_renderer_.reset();
628 demuxer_ = NULL; 659 demuxer_ = NULL;
629 660
630 // If we stop during initialization/seeking we want to run |seek_cb_| 661 // If we stop during initialization/seeking we want to run |seek_cb_|
631 // followed by |stop_cb_| so we don't leave outstanding callbacks around. 662 // followed by |stop_cb_| so we don't leave outstanding callbacks around.
632 if (!seek_cb_.is_null()) { 663 if (!seek_cb_.is_null()) {
633 base::ResetAndReturn(&seek_cb_).Run(status_); 664 base::ResetAndReturn(&seek_cb_).Run(status_);
634 error_cb_.Reset(); 665 error_cb_.Reset();
635 } 666 }
636 if (!stop_cb_.is_null()) { 667 if (!stop_cb_.is_null()) {
637 error_cb_.Reset(); 668 error_cb_.Reset();
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
678 media_log_->AddEvent(media_log_->CreateEvent(MediaLogEvent::AUDIO_ENDED)); 709 media_log_->AddEvent(media_log_->CreateEvent(MediaLogEvent::AUDIO_ENDED));
679 } 710 }
680 711
681 void Pipeline::OnVideoRendererEnded() { 712 void Pipeline::OnVideoRendererEnded() {
682 // Force post to process ended messages after current execution frame. 713 // Force post to process ended messages after current execution frame.
683 message_loop_->PostTask(FROM_HERE, base::Bind( 714 message_loop_->PostTask(FROM_HERE, base::Bind(
684 &Pipeline::DoVideoRendererEnded, base::Unretained(this))); 715 &Pipeline::DoVideoRendererEnded, base::Unretained(this)));
685 media_log_->AddEvent(media_log_->CreateEvent(MediaLogEvent::VIDEO_ENDED)); 716 media_log_->AddEvent(media_log_->CreateEvent(MediaLogEvent::VIDEO_ENDED));
686 } 717 }
687 718
719 void Pipeline::OnTextRendererEnded() {
720 // Force post to process ended messages after current execution frame.
721 message_loop_->PostTask(FROM_HERE, base::Bind(
722 &Pipeline::DoTextRendererEnded, base::Unretained(this)));
723 media_log_->AddEvent(media_log_->CreateEvent(MediaLogEvent::TEXT_ENDED));
724 }
725
688 // Called from any thread. 726 // Called from any thread.
689 void Pipeline::OnUpdateStatistics(const PipelineStatistics& stats) { 727 void Pipeline::OnUpdateStatistics(const PipelineStatistics& stats) {
690 base::AutoLock auto_lock(lock_); 728 base::AutoLock auto_lock(lock_);
691 statistics_.audio_bytes_decoded += stats.audio_bytes_decoded; 729 statistics_.audio_bytes_decoded += stats.audio_bytes_decoded;
692 statistics_.video_bytes_decoded += stats.video_bytes_decoded; 730 statistics_.video_bytes_decoded += stats.video_bytes_decoded;
693 statistics_.video_frames_decoded += stats.video_frames_decoded; 731 statistics_.video_frames_decoded += stats.video_frames_decoded;
694 statistics_.video_frames_dropped += stats.video_frames_dropped; 732 statistics_.video_frames_dropped += stats.video_frames_dropped;
695 } 733 }
696 734
697 void Pipeline::StartTask(scoped_ptr<FilterCollection> filter_collection, 735 void Pipeline::StartTask(scoped_ptr<FilterCollection> filter_collection,
698 const base::Closure& ended_cb, 736 const base::Closure& ended_cb,
699 const PipelineStatusCB& error_cb, 737 const PipelineStatusCB& error_cb,
700 const PipelineStatusCB& seek_cb, 738 const PipelineStatusCB& seek_cb,
701 const BufferingStateCB& buffering_state_cb, 739 const BufferingStateCB& buffering_state_cb,
702 const base::Closure& duration_change_cb) { 740 const base::Closure& duration_change_cb) {
703 DCHECK(message_loop_->BelongsToCurrentThread()); 741 DCHECK(message_loop_->BelongsToCurrentThread());
704 CHECK_EQ(kCreated, state_) 742 CHECK_EQ(kCreated, state_)
705 << "Media pipeline cannot be started more than once"; 743 << "Media pipeline cannot be started more than once";
706 744
707 filter_collection_ = filter_collection.Pass(); 745 filter_collection_ = filter_collection.Pass();
708 ended_cb_ = ended_cb; 746 ended_cb_ = ended_cb;
709 error_cb_ = error_cb; 747 error_cb_ = error_cb;
710 seek_cb_ = seek_cb; 748 seek_cb_ = seek_cb;
711 buffering_state_cb_ = buffering_state_cb; 749 buffering_state_cb_ = buffering_state_cb;
712 duration_change_cb_ = duration_change_cb; 750 duration_change_cb_ = duration_change_cb;
713 751
752 text_renderer_ = filter_collection_->GetTextRenderer();
753
754 if (text_renderer_) {
755 text_renderer_->Initialize(
756 base::Bind(&Pipeline::OnTextRendererEnded, base::Unretained(this)));
757 }
758
714 StateTransitionTask(PIPELINE_OK); 759 StateTransitionTask(PIPELINE_OK);
715 } 760 }
716 761
717 void Pipeline::StopTask(const base::Closure& stop_cb) { 762 void Pipeline::StopTask(const base::Closure& stop_cb) {
718 DCHECK(message_loop_->BelongsToCurrentThread()); 763 DCHECK(message_loop_->BelongsToCurrentThread());
719 DCHECK(stop_cb_.is_null()); 764 DCHECK(stop_cb_.is_null());
720 765
721 if (state_ == kStopped) { 766 if (state_ == kStopped) {
722 stop_cb.Run(); 767 stop_cb.Run();
723 return; 768 return;
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
795 return; 840 return;
796 } 841 }
797 842
798 DCHECK(seek_cb_.is_null()); 843 DCHECK(seek_cb_.is_null());
799 844
800 SetState(kSeeking); 845 SetState(kSeeking);
801 base::TimeDelta seek_timestamp = std::max(time, demuxer_->GetStartTime()); 846 base::TimeDelta seek_timestamp = std::max(time, demuxer_->GetStartTime());
802 seek_cb_ = seek_cb; 847 seek_cb_ = seek_cb;
803 audio_ended_ = false; 848 audio_ended_ = false;
804 video_ended_ = false; 849 video_ended_ = false;
850 text_ended_ = false;
805 851
806 // Kick off seeking! 852 // Kick off seeking!
807 { 853 {
808 base::AutoLock auto_lock(lock_); 854 base::AutoLock auto_lock(lock_);
809 if (clock_->IsPlaying()) 855 if (clock_->IsPlaying())
810 clock_->Pause(); 856 clock_->Pause();
811 clock_->SetTime(seek_timestamp, seek_timestamp); 857 clock_->SetTime(seek_timestamp, seek_timestamp);
812 } 858 }
813 DoSeek(seek_timestamp, base::Bind( 859 DoSeek(seek_timestamp, base::Bind(
814 &Pipeline::OnStateTransition, base::Unretained(this))); 860 &Pipeline::OnStateTransition, base::Unretained(this)));
(...skipping 23 matching lines...) Expand all
838 884
839 if (state_ != kStarted) 885 if (state_ != kStarted)
840 return; 886 return;
841 887
842 DCHECK(!video_ended_); 888 DCHECK(!video_ended_);
843 video_ended_ = true; 889 video_ended_ = true;
844 890
845 RunEndedCallbackIfNeeded(); 891 RunEndedCallbackIfNeeded();
846 } 892 }
847 893
894 void Pipeline::DoTextRendererEnded() {
895 DCHECK(message_loop_->BelongsToCurrentThread());
896
897 if (state_ != kStarted)
898 return;
899
900 DCHECK(!text_ended_);
901 text_ended_ = true;
902
903 RunEndedCallbackIfNeeded();
904 }
905
848 void Pipeline::RunEndedCallbackIfNeeded() { 906 void Pipeline::RunEndedCallbackIfNeeded() {
849 DCHECK(message_loop_->BelongsToCurrentThread()); 907 DCHECK(message_loop_->BelongsToCurrentThread());
850 908
851 if (audio_renderer_ && !audio_ended_ && !audio_disabled_) 909 if (audio_renderer_ && !audio_ended_ && !audio_disabled_)
852 return; 910 return;
853 911
854 if (video_renderer_ && !video_ended_) 912 if (video_renderer_ && !video_ended_)
855 return; 913 return;
856 914
915 if (text_renderer_ && text_renderer_->HasTracks() && !text_ended_)
916 return;
917
857 { 918 {
858 base::AutoLock auto_lock(lock_); 919 base::AutoLock auto_lock(lock_);
859 clock_->EndOfStream(); 920 clock_->EndOfStream();
860 } 921 }
861 922
862 DCHECK_EQ(status_, PIPELINE_OK); 923 DCHECK_EQ(status_, PIPELINE_OK);
863 ended_cb_.Run(); 924 ended_cb_.Run();
864 } 925 }
865 926
866 void Pipeline::AudioDisabledTask() { 927 void Pipeline::AudioDisabledTask() {
867 DCHECK(message_loop_->BelongsToCurrentThread()); 928 DCHECK(message_loop_->BelongsToCurrentThread());
868 929
869 base::AutoLock auto_lock(lock_); 930 base::AutoLock auto_lock(lock_);
870 has_audio_ = false; 931 has_audio_ = false;
871 audio_disabled_ = true; 932 audio_disabled_ = true;
872 933
873 // Notify our demuxer that we're no longer rendering audio. 934 // Notify our demuxer that we're no longer rendering audio.
874 demuxer_->OnAudioRendererDisabled(); 935 demuxer_->OnAudioRendererDisabled();
875 936
876 // Start clock since there is no more audio to trigger clock updates. 937 // Start clock since there is no more audio to trigger clock updates.
877 clock_->SetMaxTime(clock_->Duration()); 938 clock_->SetMaxTime(clock_->Duration());
878 StartClockIfWaitingForTimeUpdate_Locked(); 939 StartClockIfWaitingForTimeUpdate_Locked();
879 } 940 }
880 941
942 void Pipeline::AddTextStreamTask(DemuxerStream* text_stream,
943 TextKind kind,
944 const std::string& label,
945 const std::string& language) {
946 DCHECK(message_loop_->BelongsToCurrentThread());
947 DCHECK(text_renderer_);
acolwell GONE FROM CHROMIUM 2013/10/14 20:42:24 nit: Remove this DCHECK since we'll NPE on the nex
Matthew Heaney (Chromium) 2013/10/17 05:46:44 Done.
948 text_renderer_->AddTextStream(text_stream, kind, label, language);
949 }
950
881 void Pipeline::InitializeDemuxer(const PipelineStatusCB& done_cb) { 951 void Pipeline::InitializeDemuxer(const PipelineStatusCB& done_cb) {
882 DCHECK(message_loop_->BelongsToCurrentThread()); 952 DCHECK(message_loop_->BelongsToCurrentThread());
883 953
884 demuxer_ = filter_collection_->GetDemuxer(); 954 demuxer_ = filter_collection_->GetDemuxer();
885 demuxer_->Initialize(this, done_cb); 955 demuxer_->Initialize(this, done_cb);
886 } 956 }
887 957
888 void Pipeline::InitializeAudioRenderer(const PipelineStatusCB& done_cb) { 958 void Pipeline::InitializeAudioRenderer(const PipelineStatusCB& done_cb) {
889 DCHECK(message_loop_->BelongsToCurrentThread()); 959 DCHECK(message_loop_->BelongsToCurrentThread());
890 960
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
942 void Pipeline::StartClockIfWaitingForTimeUpdate_Locked() { 1012 void Pipeline::StartClockIfWaitingForTimeUpdate_Locked() {
943 lock_.AssertAcquired(); 1013 lock_.AssertAcquired();
944 if (!waiting_for_clock_update_) 1014 if (!waiting_for_clock_update_)
945 return; 1015 return;
946 1016
947 waiting_for_clock_update_ = false; 1017 waiting_for_clock_update_ = false;
948 clock_->Play(); 1018 clock_->Play();
949 } 1019 }
950 1020
951 } // namespace media 1021 } // namespace media
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698