Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 23664002: Replace browser_backend.options with browser_backend.find_options. (Closed)

Created:
7 years, 3 months ago by achuithb
Modified:
7 years, 3 months ago
Reviewers:
dtu, tonyg
CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org
Visibility:
Public.

Description

Replace browser_backend.options with browser_backend.find_options. All the options used by browser_backends need to be moved from finder_options to browser options. BUG=269131 TEST=trybot Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220665 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220798

Patch Set 1 : browser.py #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Patch Set 4 : newline #

Patch Set 5 : fix wpr_server.py #

Messages

Total messages: 12 (0 generated)
achuithb
Dave, in this patch I rename browser_backend.options to browser_backend.finder_options. Next I will introduce BrowserOptions as ...
7 years, 3 months ago (2013-08-28 02:33:00 UTC) #1
achuithb
On 2013/08/28 02:33:00, achuith.bhandarkar wrote: > Dave, in this patch I rename browser_backend.options to > ...
7 years, 3 months ago (2013-08-29 19:48:30 UTC) #2
achuithb
Tony, do you have time to look at this?
7 years, 3 months ago (2013-08-30 17:07:15 UTC) #3
dtu
lgtm
7 years, 3 months ago (2013-08-30 19:34:40 UTC) #4
achuithb
On 2013/08/30 19:34:40, Dave Tu wrote: > lgtm ty!
7 years, 3 months ago (2013-08-30 19:43:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achuith@chromium.org/23664002/19001
7 years, 3 months ago (2013-08-30 19:43:42 UTC) #6
commit-bot: I haz the power
Change committed as 220665
7 years, 3 months ago (2013-08-30 21:43:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achuith@chromium.org/23664002/41001
7 years, 3 months ago (2013-09-01 17:23:16 UTC) #8
achuithb
Added fix for wpr_server (lgtm'd here: https://codereview.chromium.org/23465009/)
7 years, 3 months ago (2013-09-01 17:23:28 UTC) #9
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=164384
7 years, 3 months ago (2013-09-01 20:50:02 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achuith@chromium.org/23664002/41001
7 years, 3 months ago (2013-09-01 21:03:11 UTC) #11
commit-bot: I haz the power
7 years, 3 months ago (2013-09-02 05:16:14 UTC) #12
Message was sent while issue was closed.
Change committed as 220798

Powered by Google App Engine
This is Rietveld 408576698