Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(778)

Unified Diff: tools/telemetry/telemetry/core/backends/browser_backend.py

Issue 23664002: Replace browser_backend.options with browser_backend.find_options. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix wpr_server.py Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/core/backends/browser_backend.py
diff --git a/tools/telemetry/telemetry/core/backends/browser_backend.py b/tools/telemetry/telemetry/core/backends/browser_backend.py
index 521b949c7432ac3abbf2c0e8d1f152b9b28fcd60..dc922b96cf1016686bab79ebd0f0704c48c38281 100644
--- a/tools/telemetry/telemetry/core/backends/browser_backend.py
+++ b/tools/telemetry/telemetry/core/backends/browser_backend.py
@@ -14,16 +14,17 @@ class BrowserBackend(object):
WEBPAGEREPLAY_HOST = '127.0.0.1'
- def __init__(self, is_content_shell, supports_extensions, options,
+ def __init__(self, is_content_shell, supports_extensions, finder_options,
tab_list_backend):
- self.browser_type = options.browser_type
+ self.browser_type = finder_options.browser_type
self.is_content_shell = is_content_shell
self._supports_extensions = supports_extensions
- self.options = options
+ # TODO(achuith): Replace with browser options. crbug.com/269131.
+ self.finder_options = finder_options
self._browser = None
self._tab_list_backend = tab_list_backend(self)
- def AddReplayServerOptions(self, options):
+ def AddReplayServerOptions(self, finder_options):
pass
def SetBrowser(self, browser):
@@ -41,7 +42,7 @@ class BrowserBackend(object):
@property
def wpr_mode(self):
- return self.options.wpr_mode
+ return self.finder_options.wpr_mode
@property
def supports_tab_control(self):
« no previous file with comments | « no previous file | tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698