tools/telemetry/telemetry/core/backends/webdriver/webdriver_browser_backend.py - Issue 23664002: Replace browser_backend.options with browser_backend.find_options.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/webdriver/webdriver_browser_backend.py

Issue 23664002: Replace browser_backend.options with browser_backend.find_options. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix wpr_server.py Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/backends/chrome/desktop_browser_backend.py ('k') | tools/telemetry/telemetry/core/browser.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/backends/webdriver/webdriver_browser_backend.py

diff --git a/tools/telemetry/telemetry/core/backends/webdriver/webdriver_browser_backend.py b/tools/telemetry/telemetry/core/backends/webdriver/webdriver_browser_backend.py

index 2eb01f2eb271fc273328694de3595c1024f3a2b2..eb67351556bcecfc91d0de57e9769facc97af818 100644

--- a/tools/telemetry/telemetry/core/backends/webdriver/webdriver_browser_backend.py

+++ b/tools/telemetry/telemetry/core/backends/webdriver/webdriver_browser_backend.py

@@ -10,11 +10,11 @@ class WebDriverBrowserBackend(browser_backend.BrowserBackend):

instance, on Linux, Mac, and Windows.

"""

- def __init__(self, driver_creator, supports_extensions, options):

+ def __init__(self, driver_creator, supports_extensions, finder_options):

super(WebDriverBrowserBackend, self).__init__(

is_content_shell=False,

supports_extensions=supports_extensions,

- options=options,

+ finder_options=finder_options,

tab_list_backend=webdriver_tab_list_backend.WebDriverTabListBackend)

self._driver_creator = driver_creator