Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1602)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEnginePreference.java

Issue 2362673005: [Android] Change default search engine setting page to full screen (Closed)
Patch Set: update based on Ian's new comments and Rolfe's suggestions for UI. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEnginePreference.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEnginePreference.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEnginePreference.java
deleted file mode 100644
index fbca965f2cb3a3563d552c968d90a1734b622f35..0000000000000000000000000000000000000000
--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEnginePreference.java
+++ /dev/null
@@ -1,72 +0,0 @@
-// Copyright 2015 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-package org.chromium.chrome.browser.preferences;
-
-import android.app.AlertDialog;
-import android.content.Context;
-import android.preference.DialogPreference;
-import android.util.AttributeSet;
-
-import org.chromium.base.VisibleForTesting;
-import org.chromium.chrome.R;
-
-/**
- * A dialog preference for picking a default search engine.
- */
-public class SearchEnginePreference extends DialogPreference
- implements SearchEngineAdapter.SelectSearchEngineCallback {
-
- static final String PREF_SEARCH_ENGINE = "search_engine";
-
- // The custom search engine adapter for the data to show in the dialog.
- private SearchEngineAdapter mSearchEngineAdapter;
-
- public SearchEnginePreference(Context context, AttributeSet attrs) {
- super(context, attrs);
- setEnabled(false);
- mSearchEngineAdapter = new SearchEngineAdapter(getContext(), this);
- }
-
- @VisibleForTesting
- String getValueForTesting() {
- return mSearchEngineAdapter.getValueForTesting();
- }
-
- @VisibleForTesting
- void setValueForTesting(String value) {
- mSearchEngineAdapter.setValueForTesting(value);
- }
-
- // DialogPreference:
-
- /**
- * @see DialogPreference#showDialog
- */
- public void showDialog() {
- super.showDialog(null);
- }
-
- @Override
- protected void onPrepareDialogBuilder(AlertDialog.Builder builder) {
- super.onPrepareDialogBuilder(builder);
-
- builder.setNegativeButton(null, null)
- .setPositiveButton(R.string.close, null)
- .setSingleChoiceItems(mSearchEngineAdapter, 0, null);
- }
-
- // SelectSearchEngineAdapter.SelectSearchEngineCallback:
-
- @Override
- public void currentSearchEngineDetermined(String name) {
- setSummary(name);
- setEnabled(true);
- }
-
- @Override
- public void onDismissDialog() {
- getDialog().dismiss();
- }
-}

Powered by Google App Engine
This is Rietveld 408576698