Improve handling of FF vertex array state

Improve handling of FF vertex array state

Committed: http://code.google.com/p/skia/source/detail?r=11154

[robertphillips, 2013-09-09 13:53:33]

lgtm + a nit, a question & two comment suggestions

https://codereview.chromium.org/23542013/diff/1/src/gpu/gl/GrGLVertexArray.h
File src/gpu/gl/GrGLVertexArray.h (right):

https://codereview.chromium.org/23542013/diff/1/src/gpu/gl/GrGLVertexArray.h#...
src/gpu/gl/GrGLVertexArray.h:98: fFixedFunctionVertexArray.invalidate();
Does this really need to get reset here (fUnusedFixedFunctionArraysDisabled)?

https://codereview.chromium.org/23542013/diff/1/src/gpu/gl/GrGLVertexArray.h#...
src/gpu/gl/GrGLVertexArray.h:146: 
// informative comment?

https://codereview.chromium.org/23542013/diff/1/src/gpu/gl/GrGpuGL.cpp
File src/gpu/gl/GrGpuGL.cpp (left):

https://codereview.chromium.org/23542013/diff/1/src/gpu/gl/GrGpuGL.cpp#oldcod...
src/gpu/gl/GrGpuGL.cpp:373: 
Seems like this would be a useful comment back in
GrGLAttribArrayState::disableUnusedArrays

https://codereview.chromium.org/23542013/diff/1/src/gpu/gl/GrGpuGL.h
File src/gpu/gl/GrGpuGL.h (right):

https://codereview.chromium.org/23542013/diff/1/src/gpu/gl/GrGpuGL.h#newcode305
src/gpu/gl/GrGpuGL.h:305: fDefaultVertexArrayAttribState.invalidate();
NULL !=?

[bsalomon, 2013-09-09 14:09:15]

Rob's comments and add secondary color array disable

[bsalomon, 2013-09-09 14:11:44]

https://codereview.chromium.org/23542013/diff/1/src/gpu/gl/GrGLVertexArray.h
File src/gpu/gl/GrGLVertexArray.h (right):

https://codereview.chromium.org/23542013/diff/1/src/gpu/gl/GrGLVertexArray.h#...
src/gpu/gl/GrGLVertexArray.h:98: fFixedFunctionVertexArray.invalidate();
On 2013/09/09 13:53:33, robertphillips wrote:
> Does this really need to get reset here (fUnusedFixedFunctionArraysDisabled)?

I think so... this comes from onResetContext(). The caller may have enabled
normal pointers, for example, and that could cause an access violation when we
go to draw.

https://codereview.chromium.org/23542013/diff/1/src/gpu/gl/GrGLVertexArray.h#...
src/gpu/gl/GrGLVertexArray.h:146: 
On 2013/09/09 13:53:33, robertphillips wrote:
> // informative comment?

Done.

https://codereview.chromium.org/23542013/diff/1/src/gpu/gl/GrGpuGL.cpp
File src/gpu/gl/GrGpuGL.cpp (left):

https://codereview.chromium.org/23542013/diff/1/src/gpu/gl/GrGpuGL.cpp#oldcod...
src/gpu/gl/GrGpuGL.cpp:373: 
On 2013/09/09 13:53:33, robertphillips wrote:
> Seems like this would be a useful comment back in
> GrGLAttribArrayState::disableUnusedArrays

Done.

https://codereview.chromium.org/23542013/diff/1/src/gpu/gl/GrGpuGL.h
File src/gpu/gl/GrGpuGL.h (right):

https://codereview.chromium.org/23542013/diff/1/src/gpu/gl/GrGpuGL.h#newcode305
src/gpu/gl/GrGpuGL.h:305: fDefaultVertexArrayAttribState.invalidate();
On 2013/09/09 13:53:33, robertphillips wrote:
> NULL !=?

Done.

[commit-bot: I haz the power, 2013-09-09 14:36:10]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/bsalomon@google.com/23542013/7001

[commit-bot: I haz the power, 2013-09-09 14:55:42]

Change committed as 11154