Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Unified Diff: src/gpu/gl/GrGLVertexArray.h

Issue 23542013: Improve handling of FF vertex array state (Closed) Base URL: https://skia.googlecode.com/svn/trunk
Patch Set: Rob's comments and add secondary color array disable Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/gpu/gl/GrGLDefines.h ('k') | src/gpu/gl/GrGLVertexArray.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/gpu/gl/GrGLVertexArray.h
diff --git a/src/gpu/gl/GrGLVertexArray.h b/src/gpu/gl/GrGLVertexArray.h
index 7352caf88b66518f66ee6287a56adbef862c4144..5cc7b5fd5bec7593cfd7f46b89acd454b5b157d9 100644
--- a/src/gpu/gl/GrGLVertexArray.h
+++ b/src/gpu/gl/GrGLVertexArray.h
@@ -49,7 +49,12 @@ static inline const GrGLAttribLayout& GrGLAttribTypeToLayout(GrVertexAttribType
*/
class GrGLAttribArrayState {
public:
- explicit GrGLAttribArrayState(int arrayCount = 0) { this->resize(arrayCount); }
+ explicit GrGLAttribArrayState(int arrayCount = 0) {
+ this->resize(arrayCount);
+ // glVertexPointer doesn't have a normalization param.
+ fFixedFunctionVertexArray.fNormalized = false;
+ fUnusedFixedFunctionArraysDisabled = false;
+ }
void resize(int newCount) {
fAttribArrayStates.resize_back(newCount);
@@ -72,17 +77,26 @@ public:
GrGLsizei stride,
GrGLvoid* offset);
+ void setFixedFunctionVertexArray(const GrGpuGL*,
+ GrGLVertexBuffer*,
+ GrGLint size,
+ GrGLenum type,
+ GrGLsizei stride,
+ GrGLvoid* offset);
+
/**
* This function disables vertex attribs not present in the mask. It is assumed that the
* GrGLAttribArrayState is tracking the state of the currently bound vertex array object.
*/
- void disableUnusedAttribArrays(const GrGpuGL*, uint64_t usedAttribArrayMask);
+ void disableUnusedArrays(const GrGpuGL*, uint64_t usedAttribArrayMask, bool usingFFVertexArray);
void invalidate() {
int count = fAttribArrayStates.count();
for (int i = 0; i < count; ++i) {
fAttribArrayStates[i].invalidate();
}
+ fFixedFunctionVertexArray.invalidate();
+ fUnusedFixedFunctionArraysDisabled = false;
}
void notifyVertexBufferDelete(GrGLuint id) {
@@ -93,6 +107,10 @@ public:
fAttribArrayStates[i].invalidate();
}
}
+ if (fFixedFunctionVertexArray.fAttribPointerIsValid &&
+ id == fFixedFunctionVertexArray.fVertexBufferID) {
+ fFixedFunctionVertexArray.invalidate();
+ }
}
/**
@@ -122,6 +140,13 @@ private:
};
SkSTArray<16, AttribArrayState, true> fAttribArrayStates;
+
+ // Tracks the array specified by glVertexPointer.
+ AttribArrayState fFixedFunctionVertexArray;
+
+ // Tracks whether we've disabled the other fixed function arrays that we don't
+ // use (e.g. glNormalPointer).
+ bool fUnusedFixedFunctionArraysDisabled;
};
/**
« no previous file with comments | « src/gpu/gl/GrGLDefines.h ('k') | src/gpu/gl/GrGLVertexArray.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698