New divide algorithm for Int64, final fields

New divide uses local variables rather than many temporary objects.

Removing mutators allows Int64 to have final fields and an (internal) const constructor.

R=cbracken@google.com

Committed: https://code.google.com/p/dart/source/detail?r=27588

[Chris Bracken, 2013-09-17 01:04:11]

Still reviewing _divideHelper, but sending first round.

https://codereview.chromium.org/23541010/diff/9001/pkg/fixnum/lib/src/int64.dart
File pkg/fixnum/lib/src/int64.dart (right):

https://codereview.chromium.org/23541010/diff/9001/pkg/fixnum/lib/src/int64.d...
pkg/fixnum/lib/src/int64.dart:228: return new Int64._bits(_MASK & sum0, _MASK &
sum1, _MASK2 & sum2);
return _masked(sum0, sum1, sum2)

https://codereview.chromium.org/23541010/diff/9001/pkg/fixnum/lib/src/int64.d...
pkg/fixnum/lib/src/int64.dart:353: return new Int64._bits(_MASK & ~_l, _MASK &
~_m, _MASK2 & ~_h);
_masked(~l,...)

https://codereview.chromium.org/23541010/diff/9001/pkg/fixnum/lib/src/int64.d...
pkg/fixnum/lib/src/int64.dart:377: return new Int64._bits(_MASK & res0, _MASK &
res1, _MASK2 & res2);
_masked(res0,...)

https://codereview.chromium.org/23541010/diff/9001/pkg/fixnum/lib/src/int64.d...
pkg/fixnum/lib/src/int64.dart:418: return new Int64._bits(_MASK & res0, _MASK &
res1, _MASK2 & res2);
_masked(res0,...)

https://codereview.chromium.org/23541010/diff/9001/pkg/fixnum/lib/src/int64.d...
pkg/fixnum/lib/src/int64.dart:443: return new Int64._bits(_MASK & res0, _MASK &
res1, _MASK2 & res2);
_masked(res0,...)

https://codereview.chromium.org/23541010/diff/9001/pkg/fixnum/lib/src/int64.d...
pkg/fixnum/lib/src/int64.dart:888: };
delete test code/prints

https://codereview.chromium.org/23541010/diff/9001/pkg/fixnum/lib/src/int64.d...
pkg/fixnum/lib/src/int64.dart:1051: return _sub(b0, b1, b2, r0, r1, r2);
Return 0 where r1==r2==r3==0

[sra1, 2013-09-17 05:04:35]

Fixed first set of review comments.

https://chromiumcodereview.appspot.com/23541010/diff/9001/pkg/fixnum/lib/src/...
File pkg/fixnum/lib/src/int64.dart (right):

https://chromiumcodereview.appspot.com/23541010/diff/9001/pkg/fixnum/lib/src/...
pkg/fixnum/lib/src/int64.dart:228: return new Int64._bits(_MASK & sum0, _MASK &
sum1, _MASK2 & sum2);
On 2013/09/17 01:04:11, Chris Bracken wrote:
> return _masked(sum0, sum1, sum2)

Done.

https://chromiumcodereview.appspot.com/23541010/diff/9001/pkg/fixnum/lib/src/...
pkg/fixnum/lib/src/int64.dart:353: return new Int64._bits(_MASK & ~_l, _MASK &
~_m, _MASK2 & ~_h);
On 2013/09/17 01:04:11, Chris Bracken wrote:
> _masked(~l,...)

Done.

https://chromiumcodereview.appspot.com/23541010/diff/9001/pkg/fixnum/lib/src/...
pkg/fixnum/lib/src/int64.dart:377: return new Int64._bits(_MASK & res0, _MASK &
res1, _MASK2 & res2);
On 2013/09/17 01:04:11, Chris Bracken wrote:
> _masked(res0,...)

Done.

https://chromiumcodereview.appspot.com/23541010/diff/9001/pkg/fixnum/lib/src/...
pkg/fixnum/lib/src/int64.dart:418: return new Int64._bits(_MASK & res0, _MASK &
res1, _MASK2 & res2);
On 2013/09/17 01:04:11, Chris Bracken wrote:
> _masked(res0,...)

Done.

https://chromiumcodereview.appspot.com/23541010/diff/9001/pkg/fixnum/lib/src/...
pkg/fixnum/lib/src/int64.dart:443: return new Int64._bits(_MASK & res0, _MASK &
res1, _MASK2 & res2);
On 2013/09/17 01:04:11, Chris Bracken wrote:
> _masked(res0,...)

Done.

https://chromiumcodereview.appspot.com/23541010/diff/9001/pkg/fixnum/lib/src/...
pkg/fixnum/lib/src/int64.dart:888: };
On 2013/09/17 01:04:11, Chris Bracken wrote:
> delete test code/prints

Done.

[sra1, 2013-09-17 19:42:27]

PTAL

https://chromiumcodereview.appspot.com/23541010/diff/9001/pkg/fixnum/lib/src/...
File pkg/fixnum/lib/src/int64.dart (right):

https://chromiumcodereview.appspot.com/23541010/diff/9001/pkg/fixnum/lib/src/...
pkg/fixnum/lib/src/int64.dart:1051: return _sub(b0, b1, b2, r0, r1, r2);
On 2013/09/17 01:04:11, Chris Bracken wrote:
> Return 0 where r1==r2==r3==0

Done.

[Chris Bracken, 2013-09-18 00:16:20]

lgtm

[sra1, 2013-09-18 01:02:54]

Committed patchset #3 manually as r27588 (presubmit successful).