Issue 23533044: Replace options arg with extra_wpr_args in AddReplayServerOptions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23533044: Replace options arg with extra_wpr_args in AddReplayServerOptions (Closed)

Created:
7 years, 3 months ago by achuithb

Modified:
7 years, 3 months ago

Reviewers:
tonyg

CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Replace options arg with extra_wpr_args in AddReplayServerOptions BUG=269131 TEST=trybot Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221908

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -12 lines)			Patch
M	tools/telemetry/telemetry/core/backends/browser_backend.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	tools/telemetry/telemetry/core/wpr_server.py	View	1	1 chunk	+7 lines, -7 lines	0 comments	Download

Total messages: 5 (0 generated)

achuithb

On 2013/09/06 21:51:51, tonyg wrote: > lgtm > > Great idea, thanks ty!

7 years, 3 months ago (2013-09-07 03:14:10 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achuith@chromium.org/23533044/2001

7 years, 3 months ago (2013-09-07 03:14:44 UTC) #4

Message was sent while issue was closed.

Change committed as 221908