Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Unified Diff: tools/telemetry/telemetry/core/wpr_server.py

Issue 23533044: Replace options arg with extra_wpr_args in AddReplayServerOptions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: minor Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/core/wpr_server.py
diff --git a/tools/telemetry/telemetry/core/wpr_server.py b/tools/telemetry/telemetry/core/wpr_server.py
index 0b5196b3e5f9e37362cd341a25c99392d1b3f76c..67ecff4718da459f115f9efb1bd6a395cda436b8 100644
--- a/tools/telemetry/telemetry/core/wpr_server.py
+++ b/tools/telemetry/telemetry/core/wpr_server.py
@@ -27,23 +27,23 @@ class ReplayServer(object):
util.PortPair(browser_backend.webpagereplay_local_https_port,
browser_backend.webpagereplay_remote_https_port))
- options = browser_backend.browser_options.extra_wpr_args
+ wpr_args = browser_backend.browser_options.extra_wpr_args
if self._is_record_mode:
if self._is_append_mode:
- options.append('--append')
+ wpr_args.append('--append')
else:
- options.append('--record')
+ wpr_args.append('--record')
if not make_javascript_deterministic:
- options.append('--inject_scripts=')
- browser_backend.AddReplayServerOptions(options)
+ wpr_args.append('--inject_scripts=')
+ browser_backend.AddReplayServerOptions(wpr_args)
self._web_page_replay = webpagereplay.ReplayServer(
path,
browser_backend.WEBPAGEREPLAY_HOST,
browser_backend.webpagereplay_local_http_port,
browser_backend.webpagereplay_local_https_port,
- options)
+ wpr_args)
# Remove --no-dns_forwarding if it wasn't explicitly requested by backend.
- if '--no-dns_forwarding' not in options:
+ if '--no-dns_forwarding' not in wpr_args:
self._web_page_replay.replay_options.remove('--no-dns_forwarding')
self._web_page_replay.StartServer()
« no previous file with comments | « tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698