tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py - Issue 23533044: Replace options arg with extra_wpr_args in AddReplayServerOptions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py

Issue 23533044: Replace options arg with extra_wpr_args in AddReplayServerOptions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: minor Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/backends/browser_backend.py ('k') | tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py

diff --git a/tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py b/tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py

index 304d142a86b17649ae84a02bd521c9b014159a25..69339d717d3850f2a85acbdb21f5534e4d2b54db 100644

--- a/tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py

+++ b/tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py

@@ -341,10 +341,10 @@ class AndroidBrowserBackend(chrome_browser_backend.ChromeBrowserBackend):

stdout=subprocess.PIPE).communicate()[0])

return ret

- def AddReplayServerOptions(self, options):

+ def AddReplayServerOptions(self, extra_wpr_args):

"""Override. Only add --no-dns_forwarding if not using RNDIS."""

if not self._override_dns:

- options.append('--no-dns_forwarding')

+ extra_wpr_args.append('--no-dns_forwarding')

def CreateForwarder(self, *port_pairs):

if self._rndis_forwarder: