Remove NOTIFICATION_SYSTEM_SETTING_CHANGED, switch CrosSettings to base::CallbackRegistry.

Remove NOTIFICATION_SYSTEM_SETTING_CHANGED, switch CrosSettings to base::CallbackRegistry.

BUG=268984
TEST=no change

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=224229

[Avi (use Gerrit), 2013-09-17 19:51:00]

mnissler: chrome/browser/chromeos/(attestation|policy|settings)
zelidrag: chrome/browser/chromeos/(app_mode|login),
chrome/browser/ui/webui/chromeos
nkostylev: chrome/browser/ui/webui/options
thestig: chrome/browser/chrome_notification_types.h

[Avi (use Gerrit), 2013-09-17 20:30:11]

On 2013/09/17 19:51:00, Avi wrote:
> mnissler: chrome/browser/chromeos/(attestation|policy|settings)
> zelidrag: chrome/browser/chromeos/(app_mode|login),
> chrome/browser/ui/webui/chromeos
> nkostylev: chrome/browser/ui/webui/options
> thestig: chrome/browser/chrome_notification_types.h

Pause; turns out I missed some tests. Don't review yet.

[Avi (use Gerrit), 2013-09-17 23:09:21]

On 2013/09/17 20:30:11, Avi wrote:
> On 2013/09/17 19:51:00, Avi wrote:
> > mnissler: chrome/browser/chromeos/(attestation|policy|settings)
> > zelidrag: chrome/browser/chromeos/(app_mode|login),
> > chrome/browser/ui/webui/chromeos
> > nkostylev: chrome/browser/ui/webui/options
> > thestig: chrome/browser/chrome_notification_types.h
> 
> Pause; turns out I missed some tests. Don't review yet.

OK! I'm ready; please review.

[Lei Zhang, 2013-09-18 05:00:53]

https://codereview.chromium.org/23494053/diff/31001/chrome/browser/chromeos/a...
File chrome/browser/chromeos/attestation/attestation_policy_observer.h (right):

https://codereview.chromium.org/23494053/diff/31001/chrome/browser/chromeos/a...
chrome/browser/chromeos/attestation/attestation_policy_observer.h:46: virtual
~AttestationPolicyObserver();
no longer needs to be virtual?

https://codereview.chromium.org/23494053/diff/31001/chrome/browser/chromeos/l...
File chrome/browser/chromeos/login/existing_user_controller.cc (right):

https://codereview.chromium.org/23494053/diff/31001/chrome/browser/chromeos/l...
chrome/browser/chromeos/login/existing_user_controller.cc:934: void
ExistingUserController::SettingsChanged() {
Not sure if this is this equivalent to the old code. I'm leaving it to the other
reviewers to have a closer look.

https://codereview.chromium.org/23494053/diff/31001/chrome/browser/chromeos/l...
File chrome/browser/chromeos/login/version_info_updater.cc (right):

https://codereview.chromium.org/23494053/diff/31001/chrome/browser/chromeos/l...
chrome/browser/chromeos/login/version_info_updater.cc:73:
base::Bind(&VersionInfoUpdater::UpdateEnterpriseInfo,
Can you assign this to a base::Closure variable and re-use it in the 4 different
AddSettingsObserver() calls?

https://codereview.chromium.org/23494053/diff/31001/chrome/browser/chromeos/p...
File chrome/browser/chromeos/policy/app_pack_updater.cc (right):

https://codereview.chromium.org/23494053/diff/31001/chrome/browser/chromeos/p...
chrome/browser/chromeos/policy/app_pack_updater.cc:16: #include
"content/public/browser/notification_details.h"
Remove

https://codereview.chromium.org/23494053/diff/31001/chrome/browser/chromeos/p...
File chrome/browser/chromeos/policy/device_local_account_policy_service.cc
(right):

https://codereview.chromium.org/23494053/diff/31001/chrome/browser/chromeos/p...
chrome/browser/chromeos/policy/device_local_account_policy_service.cc:25:
#include "content/public/browser/notification_details.h"
Remove

https://codereview.chromium.org/23494053/diff/31001/chrome/browser/chromeos/p...
File chrome/browser/chromeos/policy/device_status_collector.cc (right):

https://codereview.chromium.org/23494053/diff/31001/chrome/browser/chromeos/p...
chrome/browser/chromeos/policy/device_status_collector.cc:30: #include
"content/public/browser/notification_details.h"
Remove

https://codereview.chromium.org/23494053/diff/31001/chrome/browser/chromeos/s...
File chrome/browser/chromeos/settings/cros_settings.cc (right):

https://codereview.chromium.org/23494053/diff/31001/chrome/browser/chromeos/s...
chrome/browser/chromeos/settings/cros_settings.cc:19: #include
"content/public/browser/notification_details.h"
Remove

https://codereview.chromium.org/23494053/diff/31001/chrome/browser/chromeos/s...
chrome/browser/chromeos/settings/cros_settings.cc:267: const char* path, const
base::Closure& callback) {
Why can't |path| be a const std::string& ?

[Darren Krahn, 2013-09-18 09:05:37]

https://codereview.chromium.org/23494053/diff/31001/chrome/browser/chromeos/a...
File chrome/browser/chromeos/attestation/attestation_policy_observer.cc (left):

https://codereview.chromium.org/23494053/diff/31001/chrome/browser/chromeos/a...
chrome/browser/chromeos/attestation/attestation_policy_observer.cc:134:
DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
Was removing this DCHECK intentional?  If so, we may want to schedule the
Start() call below on the UI thread.

[Mattias Nissler (ping if slow), 2013-09-18 09:09:48]

chrome/browser/chromeos/(attestation|policy|settings) LGTM with nits. Please
consider the comments I put elsewhere though.

https://codereview.chromium.org/23494053/diff/31001/chrome/browser/chromeos/a...
File chrome/browser/chromeos/app_mode/kiosk_app_manager.cc (right):

https://codereview.chromium.org/23494053/diff/31001/chrome/browser/chromeos/a...
chrome/browser/chromeos/app_mode/kiosk_app_manager.cc:18: #include
"chrome/browser/chrome_notification_types.h"
remove?

https://codereview.chromium.org/23494053/diff/31001/chrome/browser/chromeos/l...
File chrome/browser/chromeos/login/existing_user_controller.cc (right):

https://codereview.chromium.org/23494053/diff/31001/chrome/browser/chromeos/l...
chrome/browser/chromeos/login/existing_user_controller.cc:934: void
ExistingUserController::SettingsChanged() {
On 2013/09/18 05:00:53, Lei Zhang wrote:
> Not sure if this is this equivalent to the old code. I'm leaving it to the
other
> reviewers to have a closer look.

The old code doesn't make much sense either ;)

I think this should actually be split into two callbacks. Calling
ConfigurePublicSessionAutoLogin() is sufficient for
kAccountsPrefDeviceLocalAccountAutoLoginId and
kAccountsPrefDeviceLocalAccountAutoLoginDelay. The remaining observed settings
should be wired to SettingsChanged() (which should retain the call to
ConfigurePublicSessionAutoLogin()).

https://codereview.chromium.org/23494053/diff/31001/chrome/browser/chromeos/l...
File chrome/browser/chromeos/login/existing_user_controller.h (right):

https://codereview.chromium.org/23494053/diff/31001/chrome/browser/chromeos/l...
chrome/browser/chromeos/login/existing_user_controller.h:151: // Called when the
settings change.
For clarity, rather "Called when device settings change.". Can you also rename
SettingsChanged() to DeviceSettingsChanged()?

https://codereview.chromium.org/23494053/diff/31001/chrome/browser/chromeos/l...
chrome/browser/chromeos/login/existing_user_controller.h:312:
local_account_auto_login_delay_subscription_;
This is quite some boilerplate and lots of small heap-allocated objects. I
assume this has thoroughly been discussed and measured and found to be
acceptable if the entire code base were to be converted to this style?

https://codereview.chromium.org/23494053/diff/31001/chrome/browser/chromeos/l...
File chrome/browser/chromeos/login/version_info_updater.cc (right):

https://codereview.chromium.org/23494053/diff/31001/chrome/browser/chromeos/l...
chrome/browser/chromeos/login/version_info_updater.cc:16: #include
"chrome/browser/chrome_notification_types.h"
remove?

https://codereview.chromium.org/23494053/diff/31001/chrome/browser/chromeos/l...
chrome/browser/chromeos/login/version_info_updater.cc:73:
base::Bind(&VersionInfoUpdater::UpdateEnterpriseInfo,
On 2013/09/18 05:00:53, Lei Zhang wrote:
> Can you assign this to a base::Closure variable and re-use it in the 4
different
> AddSettingsObserver() calls?

Could also keep the array and loop in that case and switch to a ScopedVector for
the subscriptions.

https://codereview.chromium.org/23494053/diff/31001/chrome/browser/chromeos/l...
File chrome/browser/chromeos/login/wallpaper_manager.cc (right):

https://codereview.chromium.org/23494053/diff/31001/chrome/browser/chromeos/l...
chrome/browser/chromeos/login/wallpaper_manager.cc:166: no_observers_ = true;
You probably want to nuke |no_observers_| and replace the DCHECK in line 159
with DCHECK(!show_user_name_on_signin_subscription_).

https://codereview.chromium.org/23494053/diff/31001/chrome/browser/chromeos/p...
File chrome/browser/chromeos/policy/app_pack_updater.h (right):

https://codereview.chromium.org/23494053/diff/31001/chrome/browser/chromeos/p...
chrome/browser/chromeos/policy/app_pack_updater.h:70: // Called when settings
change.
"Called when the app pack device setting changes."

https://codereview.chromium.org/23494053/diff/31001/chrome/browser/chromeos/p...
chrome/browser/chromeos/policy/app_pack_updater.h:71: void SettingChanged();
Rename to AppPackChanged()

https://codereview.chromium.org/23494053/diff/31001/chrome/browser/chromeos/p...
File chrome/browser/chromeos/policy/device_status_collector.cc (right):

https://codereview.chromium.org/23494053/diff/31001/chrome/browser/chromeos/p...
chrome/browser/chromeos/policy/device_status_collector.cc:153:
base::Bind(&DeviceStatusCollector::UpdateReportingSettings,
This can probably be made more readable by declaring a base::Closure local for
UpdateReportingSettings and using it for all AddSettingObservers calls.

https://codereview.chromium.org/23494053/diff/31001/chrome/browser/chromeos/s...
File chrome/browser/chromeos/settings/cros_settings.cc (right):

https://codereview.chromium.org/23494053/diff/31001/chrome/browser/chromeos/s...
chrome/browser/chromeos/settings/cros_settings.cc:267: const char* path, const
base::Closure& callback) {
nit: parameters on separate lines.

https://codereview.chromium.org/23494053/diff/31001/chrome/browser/chromeos/s...
File chrome/browser/chromeos/settings/cros_settings.h (right):

https://codereview.chromium.org/23494053/diff/31001/chrome/browser/chromeos/s...
chrome/browser/chromeos/settings/cros_settings.h:15: #include
"base/observer_list.h"
remove

https://codereview.chromium.org/23494053/diff/31001/chrome/browser/chromeos/s...
chrome/browser/chromeos/settings/cros_settings.h:19: #include
"content/public/browser/notification_observer.h"
remove

https://codereview.chromium.org/23494053/diff/31001/chrome/browser/chromeos/s...
chrome/browser/chromeos/settings/cros_settings.h:101: const char* path, const
base::Closure& callback);
nit: parameters on separate lines

https://codereview.chromium.org/23494053/diff/31001/chrome/browser/ui/webui/o...
File chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc
(right):

https://codereview.chromium.org/23494053/diff/31001/chrome/browser/ui/webui/o...
chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc:15:
#include "chrome/browser/chrome_notification_types.h"
remove

https://codereview.chromium.org/23494053/diff/31001/chrome/browser/ui/webui/o...
chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc:25:
#include "content/public/browser/notification_details.h"
remove

https://codereview.chromium.org/23494053/diff/31001/chrome/browser/ui/webui/o...
chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc:178:
subscription.release());
Shouldn't you be able to just declare |subscription| a linked_ptr if you add a
.release() on the return value of AddSettingsObserver?

[zel, 2013-09-18 16:35:37]

+xiyuan

[Avi (use Gerrit), 2013-09-18 16:41:44]

https://codereview.chromium.org/23494053/diff/31001/chrome/browser/chromeos/a...
File chrome/browser/chromeos/app_mode/kiosk_app_manager.cc (right):

https://codereview.chromium.org/23494053/diff/31001/chrome/browser/chromeos/a...
chrome/browser/chromeos/app_mode/kiosk_app_manager.cc:18: #include
"chrome/browser/chrome_notification_types.h"
On 2013/09/18 09:09:48, Mattias Nissler wrote:
> remove?

Done.

https://codereview.chromium.org/23494053/diff/31001/chrome/browser/chromeos/a...
File chrome/browser/chromeos/attestation/attestation_policy_observer.cc (left):

https://codereview.chromium.org/23494053/diff/31001/chrome/browser/chromeos/a...
chrome/browser/chromeos/attestation/attestation_policy_observer.cc:134:
DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
On 2013/09/18 09:05:37, Darren Krahn wrote:
> Was removing this DCHECK intentional?  If so, we may want to schedule the
> Start() call below on the UI thread.

Not intentional. I'll re-insert.

https://codereview.chromium.org/23494053/diff/31001/chrome/browser/chromeos/a...
File chrome/browser/chromeos/attestation/attestation_policy_observer.h (right):

https://codereview.chromium.org/23494053/diff/31001/chrome/browser/chromeos/a...
chrome/browser/chromeos/attestation/attestation_policy_observer.h:46: virtual
~AttestationPolicyObserver();
On 2013/09/18 05:00:53, Lei Zhang wrote:
> no longer needs to be virtual?

Done.

https://codereview.chromium.org/23494053/diff/31001/chrome/browser/chromeos/l...
File chrome/browser/chromeos/login/existing_user_controller.cc (right):

https://codereview.chromium.org/23494053/diff/31001/chrome/browser/chromeos/l...
chrome/browser/chromeos/login/existing_user_controller.cc:934: void
ExistingUserController::SettingsChanged() {
On 2013/09/18 09:09:48, Mattias Nissler wrote:
> The old code doesn't make much sense either ;)

Tell me about it.

> I think this should actually be split into two callbacks. Calling
> ConfigurePublicSessionAutoLogin() is sufficient for
> kAccountsPrefDeviceLocalAccountAutoLoginId and
> kAccountsPrefDeviceLocalAccountAutoLoginDelay. The remaining observed settings
> should be wired to SettingsChanged() (which should retain the call to
> ConfigurePublicSessionAutoLogin()).

Done.

https://codereview.chromium.org/23494053/diff/31001/chrome/browser/chromeos/l...
File chrome/browser/chromeos/login/existing_user_controller.h (right):

https://codereview.chromium.org/23494053/diff/31001/chrome/browser/chromeos/l...
chrome/browser/chromeos/login/existing_user_controller.h:151: // Called when the
settings change.
On 2013/09/18 09:09:48, Mattias Nissler wrote:
> For clarity, rather "Called when device settings change.". Can you also rename
> SettingsChanged() to DeviceSettingsChanged()?

Done.

https://codereview.chromium.org/23494053/diff/31001/chrome/browser/chromeos/l...
chrome/browser/chromeos/login/existing_user_controller.h:312:
local_account_auto_login_delay_subscription_;
On 2013/09/18 09:09:48, Mattias Nissler wrote:
> This is quite some boilerplate and lots of small heap-allocated objects. I
> assume this has thoroughly been discussed and measured and found to be
> acceptable if the entire code base were to be converted to this style?

If you want I can bring this up as a specific example on cr-dev for discussion.

https://codereview.chromium.org/23494053/diff/31001/chrome/browser/chromeos/l...
File chrome/browser/chromeos/login/version_info_updater.cc (right):

https://codereview.chromium.org/23494053/diff/31001/chrome/browser/chromeos/l...
chrome/browser/chromeos/login/version_info_updater.cc:16: #include
"chrome/browser/chrome_notification_types.h"
On 2013/09/18 09:09:48, Mattias Nissler wrote:
> remove?

Done.

https://codereview.chromium.org/23494053/diff/31001/chrome/browser/chromeos/l...
chrome/browser/chromeos/login/version_info_updater.cc:73:
base::Bind(&VersionInfoUpdater::UpdateEnterpriseInfo,
On 2013/09/18 09:09:48, Mattias Nissler wrote:
> On 2013/09/18 05:00:53, Lei Zhang wrote:
> > Can you assign this to a base::Closure variable and re-use it in the 4
> different
> > AddSettingsObserver() calls?
> 
> Could also keep the array and loop in that case and switch to a ScopedVector
for
> the subscriptions.

Done.

https://codereview.chromium.org/23494053/diff/31001/chrome/browser/chromeos/l...
File chrome/browser/chromeos/login/wallpaper_manager.cc (right):

https://codereview.chromium.org/23494053/diff/31001/chrome/browser/chromeos/l...
chrome/browser/chromeos/login/wallpaper_manager.cc:166: no_observers_ = true;
On 2013/09/18 09:09:48, Mattias Nissler wrote:
> You probably want to nuke |no_observers_| and replace the DCHECK in line 159
> with DCHECK(!show_user_name_on_signin_subscription_).

Done.

https://codereview.chromium.org/23494053/diff/31001/chrome/browser/chromeos/p...
File chrome/browser/chromeos/policy/app_pack_updater.cc (right):

https://codereview.chromium.org/23494053/diff/31001/chrome/browser/chromeos/p...
chrome/browser/chromeos/policy/app_pack_updater.cc:16: #include
"content/public/browser/notification_details.h"
On 2013/09/18 05:00:53, Lei Zhang wrote:
> Remove

Done.

https://codereview.chromium.org/23494053/diff/31001/chrome/browser/chromeos/p...
File chrome/browser/chromeos/policy/app_pack_updater.h (right):

https://codereview.chromium.org/23494053/diff/31001/chrome/browser/chromeos/p...
chrome/browser/chromeos/policy/app_pack_updater.h:70: // Called when settings
change.
On 2013/09/18 09:09:48, Mattias Nissler wrote:
> "Called when the app pack device setting changes."

Done.

https://codereview.chromium.org/23494053/diff/31001/chrome/browser/chromeos/p...
chrome/browser/chromeos/policy/app_pack_updater.h:71: void SettingChanged();
On 2013/09/18 09:09:48, Mattias Nissler wrote:
> Rename to AppPackChanged()

Done.

https://codereview.chromium.org/23494053/diff/31001/chrome/browser/chromeos/p...
File chrome/browser/chromeos/policy/device_local_account_policy_service.cc
(right):

https://codereview.chromium.org/23494053/diff/31001/chrome/browser/chromeos/p...
chrome/browser/chromeos/policy/device_local_account_policy_service.cc:25:
#include "content/public/browser/notification_details.h"
On 2013/09/18 05:00:53, Lei Zhang wrote:
> Remove

Done.

https://codereview.chromium.org/23494053/diff/31001/chrome/browser/chromeos/p...
File chrome/browser/chromeos/policy/device_status_collector.cc (right):

https://codereview.chromium.org/23494053/diff/31001/chrome/browser/chromeos/p...
chrome/browser/chromeos/policy/device_status_collector.cc:153:
base::Bind(&DeviceStatusCollector::UpdateReportingSettings,
On 2013/09/18 09:09:48, Mattias Nissler wrote:
> This can probably be made more readable by declaring a base::Closure local for
> UpdateReportingSettings and using it for all AddSettingObservers calls.

Done.

https://codereview.chromium.org/23494053/diff/31001/chrome/browser/chromeos/s...
File chrome/browser/chromeos/settings/cros_settings.cc (right):

https://codereview.chromium.org/23494053/diff/31001/chrome/browser/chromeos/s...
chrome/browser/chromeos/settings/cros_settings.cc:19: #include
"content/public/browser/notification_details.h"
On 2013/09/18 05:00:53, Lei Zhang wrote:
> Remove

Done.

https://codereview.chromium.org/23494053/diff/31001/chrome/browser/chromeos/s...
chrome/browser/chromeos/settings/cros_settings.cc:267: const char* path, const
base::Closure& callback) {
On 2013/09/18 05:00:53, Lei Zhang wrote:
> Why can't |path| be a const std::string& ?

It's been that way since day 1, three years ago:
https://codereview.chromium.org/3143009

However...

If you look at browser/chromeos/login/version_info_updater, it uses a loop to
register interest, and you can't define a vector of string objects.

https://codereview.chromium.org/23494053/diff/31001/chrome/browser/chromeos/s...
chrome/browser/chromeos/settings/cros_settings.cc:267: const char* path, const
base::Closure& callback) {
On 2013/09/18 09:09:48, Mattias Nissler wrote:
> nit: parameters on separate lines.

Done.

https://codereview.chromium.org/23494053/diff/31001/chrome/browser/chromeos/s...
File chrome/browser/chromeos/settings/cros_settings.h (right):

https://codereview.chromium.org/23494053/diff/31001/chrome/browser/chromeos/s...
chrome/browser/chromeos/settings/cros_settings.h:101: const char* path, const
base::Closure& callback);
On 2013/09/18 09:09:48, Mattias Nissler wrote:
> nit: parameters on separate lines

Done.

https://codereview.chromium.org/23494053/diff/31001/chrome/browser/ui/webui/o...
File chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc
(right):

https://codereview.chromium.org/23494053/diff/31001/chrome/browser/ui/webui/o...
chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc:15:
#include "chrome/browser/chrome_notification_types.h"
On 2013/09/18 09:09:48, Mattias Nissler wrote:
> remove

Done.

https://codereview.chromium.org/23494053/diff/31001/chrome/browser/ui/webui/o...
chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc:25:
#include "content/public/browser/notification_details.h"
On 2013/09/18 09:09:48, Mattias Nissler wrote:
> remove

Done.

https://codereview.chromium.org/23494053/diff/31001/chrome/browser/ui/webui/o...
chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc:178:
subscription.release());
On 2013/09/18 09:09:48, Mattias Nissler wrote:
> Shouldn't you be able to just declare |subscription| a linked_ptr if you add a
> .release() on the return value of AddSettingsObserver?

Done.

[xiyuan, 2013-09-18 18:38:33]

chrome/browser/chromeos/login/*
chrome/browser/ui/webui/*

LGTM

[Avi (use Gerrit), 2013-09-18 18:50:37]

https://codereview.chromium.org/23494053/diff/31001/chrome/browser/chromeos/s...
File chrome/browser/chromeos/settings/cros_settings.cc (right):

https://codereview.chromium.org/23494053/diff/31001/chrome/browser/chromeos/s...
chrome/browser/chromeos/settings/cros_settings.cc:267: const char* path, const
base::Closure& callback) {
Actually, you're right in that you will construct a temporary. Lemme try that.

[Lei Zhang, 2013-09-18 18:51:06]

chrome/browser/chrome_notification_types.h lgtm

https://codereview.chromium.org/23494053/diff/31001/chrome/browser/chromeos/l...
File chrome/browser/chromeos/login/version_info_updater.cc (right):

https://codereview.chromium.org/23494053/diff/31001/chrome/browser/chromeos/l...
chrome/browser/chromeos/login/version_info_updater.cc:73:
base::Bind(&VersionInfoUpdater::UpdateEnterpriseInfo,
On 2013/09/18 16:41:44, Avi wrote:
> On 2013/09/18 09:09:48, Mattias Nissler wrote:
> > On 2013/09/18 05:00:53, Lei Zhang wrote:
> > > Can you assign this to a base::Closure variable and re-use it in the 4
> > different
> > > AddSettingsObserver() calls?
> > 
> > Could also keep the array and loop in that case and switch to a ScopedVector
> for
> > the subscriptions.
> 
> Done.

chrome/browser/chromeos/login/existing_user_controller.cc can probably use the
same treatment.

[Avi (use Gerrit), 2013-09-18 19:39:07]

https://codereview.chromium.org/23494053/diff/31001/chrome/browser/chromeos/l...
File chrome/browser/chromeos/login/version_info_updater.cc (right):

https://codereview.chromium.org/23494053/diff/31001/chrome/browser/chromeos/l...
chrome/browser/chromeos/login/version_info_updater.cc:73:
base::Bind(&VersionInfoUpdater::UpdateEnterpriseInfo,
If you look at ExistingUserControllerAutoLoginTest, it explicitly resets two of
the six notifications, so I'd have to use a loop for four notifications while
keeping those two separate. That's weird :(

[Avi (use Gerrit), 2013-09-19 00:28:20]

nkostylev: ping

[Nikita (slow), 2013-09-19 07:55:14]

lgtm, thanks!

Please run cros* trybots as well

[commit-bot: I haz the power, 2013-09-19 18:40:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/avi@chromium.org/23494053/57001

[commit-bot: I haz the power, 2013-09-19 18:58:23]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[commit-bot: I haz the power, 2013-09-19 19:16:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/avi@chromium.org/23494053/52001

[commit-bot: I haz the power, 2013-09-19 23:27:37]

Change committed as 224229