Remove NOTIFICATION_SYSTEM_SETTING_CHANGED, switch CrosSettings to base::CallbackRegistry.

chrome/browser/chromeos/login/existing_user_controller_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <vector>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/callback.h"
 #include "base/command_line.h"
 #include "base/location.h"
+#include "base/memory/ref_counted.h"
 #include "base/run_loop.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/chromeos/login/authenticator.h"
 #include "chrome/browser/chromeos/login/existing_user_controller.h"
 #include "chrome/browser/chromeos/login/helper.h"
 #include "chrome/browser/chromeos/login/mock_authenticator.h"
 #include "chrome/browser/chromeos/login/mock_login_display.h"
 #include "chrome/browser/chromeos/login/mock_login_display_host.h"
 #include "chrome/browser/chromeos/login/mock_login_utils.h"
 #include "chrome/browser/chromeos/login/mock_url_fetchers.h"
@@ skipping 423 matching lines @@
     EXPECT_CALL(*mock_login_display_, SetUIEnabled(true))
         .Times(1);
     EXPECT_CALL(*mock_login_display_, OnFadeOut())
         .Times(1);
     EXPECT_CALL(*mock_login_display_host_,
                 StartWizardPtr(WizardController::kTermsOfServiceScreenName,
                                NULL))
         .Times(0);
   }
 
-  scoped_ptr<base::RunLoop> CreateSettingsObserverRunLoop(
-      content::MockNotificationObserver& observer, const char* setting) {
-    base::RunLoop* loop = new base::RunLoop;
-    EXPECT_CALL(observer, Observe(chrome::NOTIFICATION_SYSTEM_SETTING_CHANGED,
-                                  _, HasDetails(setting)))
-        .Times(1)
-        .WillOnce(InvokeWithoutArgs(loop, &base::RunLoop::Quit));
-    CrosSettings::Get()->AddSettingsObserver(setting, &observer);
-    return make_scoped_ptr(loop);
-  }
-
   void SetAutoLoginPolicy(const std::string& username, int delay) {
     // Wait until ExistingUserController has finished auto-login
     // configuration by observing the same settings that trigger
     // ConfigurePublicSessionAutoLogin.
-    content::MockNotificationObserver observer;
 
     em::ChromeDeviceSettingsProto& proto(device_policy()->payload());
 
     // If both settings have changed we need to wait for both to
     // propagate, so check the new values against the old ones.
-    scoped_ptr<base::RunLoop> runner1;
+    scoped_refptr<content::MessageLoopRunner> runner1;
+    scoped_ptr<CrosSettings::ObserverSubscription> subscription1;
     if (!proto.has_device_local_accounts() ||
         !proto.device_local_accounts().has_auto_login_id() ||
         proto.device_local_accounts().auto_login_id() != username) {
-      runner1 = CreateSettingsObserverRunLoop(
-          observer, kAccountsPrefDeviceLocalAccountAutoLoginId);
+      runner1 = new content::MessageLoopRunner;
+      subscription1 = chromeos::CrosSettings::Get()->AddSettingsObserver(
+          chromeos::kAccountsPrefDeviceLocalAccountAutoLoginId,
+          runner1->QuitClosure());
     }
-    scoped_ptr<base::RunLoop> runner2;
+    scoped_refptr<content::MessageLoopRunner> runner2;
+    scoped_ptr<CrosSettings::ObserverSubscription> subscription2;
     if (!proto.has_device_local_accounts() ||
         !proto.device_local_accounts().has_auto_login_delay() ||
         proto.device_local_accounts().auto_login_delay() != delay) {
-      runner2 = CreateSettingsObserverRunLoop(
-          observer, kAccountsPrefDeviceLocalAccountAutoLoginDelay);
+      runner1 = new content::MessageLoopRunner;
+      subscription1 = chromeos::CrosSettings::Get()->AddSettingsObserver(
+          chromeos::kAccountsPrefDeviceLocalAccountAutoLoginDelay,
+          runner1->QuitClosure());
     }
 
     // Update the policy.
     proto.mutable_device_local_accounts()->set_auto_login_id(username);
     proto.mutable_device_local_accounts()->set_auto_login_delay(delay);
     RefreshDevicePolicy();
 
     // Wait for ExistingUserController to read the updated settings.
-    if (runner1)
+    if (runner1.get())
       runner1->Run();
-    if (runner2)
+    if (runner2.get())
       runner2->Run();
-
-    // Clean up.
-    CrosSettings::Get()->RemoveSettingsObserver(
-        kAccountsPrefDeviceLocalAccountAutoLoginId,
-        &observer);
-    CrosSettings::Get()->RemoveSettingsObserver(
-        kAccountsPrefDeviceLocalAccountAutoLoginDelay,
-        &observer);
   }
 
   void ConfigureAutoLogin() {
     existing_user_controller()->ConfigurePublicSessionAutoLogin();
   }
 
   void FireAutoLogin() {
     existing_user_controller()->OnPublicSessionAutoLoginTimerFire();
   }
 
@@ skipping 159 matching lines @@
 
 INSTANTIATE_TEST_CASE_P(ExistingUserControllerTestInstantiation,
                         ExistingUserControllerTest,
                         testing::Bool());
 
 INSTANTIATE_TEST_CASE_P(ExistingUserControllerPublicSessionTestInstantiation,
                         ExistingUserControllerPublicSessionTest,
                         testing::Bool());
 
 }  // namespace chromeos