Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Issue 23494039: [android] Relands: Adds constants.GetBuildDirectory() and converts test scripts to use it. (Closed)

Created:
7 years, 3 months ago by craigdh
Modified:
7 years, 3 months ago
Reviewers:
bulach, frankf
CC:
chromium-reviews, craigdh+watch_chromium.org, chrome-speed-team+watch_google.com, anantha, bulach+watch_chromium.org, yfriedman+watch_chromium.org, dyu1, ilevy-cc_chromium.org, dennis_jeffrey, klundberg+watch_chromium.org, telemetry+watch_chromium.org, frankf+watch_chromium.org, johnme
Visibility:
Public.

Description

[android] Relands: Adds constants.GetBuildDirectory() and converts test scripts to use it. BUG=260494 TEST=None NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222313

Patch Set 1 #

Patch Set 2 : fix provision_devices.py which never set the build type #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -90 lines) Patch
M build/android/adb_install_apk.py View 2 chunks +3 lines, -3 lines 0 comments Download
M build/android/adb_reverse_forwarder.py View 2 chunks +3 lines, -2 lines 0 comments Download
M build/android/provision_devices.py View 1 1 chunk +1 line, -0 lines 0 comments Download
M build/android/pylib/android_commands.py View 3 chunks +7 lines, -14 lines 0 comments Download
M build/android/pylib/base/base_test_runner.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/pylib/chrome_test_server_spawner.py View 1 chunk +1 line, -2 lines 0 comments Download
M build/android/pylib/cmd_helper.py View 1 chunk +0 lines, -11 lines 0 comments Download
M build/android/pylib/constants.py View 1 chunk +12 lines, -0 lines 0 comments Download
M build/android/pylib/device_stats_monitor.py View 1 chunk +2 lines, -3 lines 0 comments Download
M build/android/pylib/fake_dns.py View 1 chunk +1 line, -2 lines 0 comments Download
M build/android/pylib/forwarder.py View 6 chunks +12 lines, -24 lines 0 comments Download
M build/android/pylib/gtest/setup.py View 2 chunks +2 lines, -6 lines 0 comments Download
M build/android/pylib/gtest/test_package_apk.py View 1 chunk +3 lines, -4 lines 0 comments Download
M build/android/pylib/gtest/test_package_exe.py View 1 chunk +3 lines, -4 lines 0 comments Download
M build/android/pylib/host_driven/test_case.py View 1 chunk +3 lines, -2 lines 0 comments Download
M build/android/pylib/utils/report_results.py View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/test/functional/ispy/ispy_core/tools/reverse_port_forwarder.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/backends/adb_commands.py View 4 chunks +12 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
craigdh
Patchset #1 has already been reviewed at https://codereview.chromium.org/22903016/. It caused the webkit android bots to ...
7 years, 3 months ago (2013-09-09 20:21:34 UTC) #1
frankf
lgtm
7 years, 3 months ago (2013-09-09 20:25:19 UTC) #2
bulach
lgtm, thanks!
7 years, 3 months ago (2013-09-10 08:42:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/craigdh@chromium.org/23494039/3001
7 years, 3 months ago (2013-09-10 18:22:11 UTC) #4
commit-bot: I haz the power
7 years, 3 months ago (2013-09-10 18:29:07 UTC) #5
Message was sent while issue was closed.
Change committed as 222313

Powered by Google App Engine
This is Rietveld 408576698