build/android/adb_reverse_forwarder.py - Issue 23494039: [android] Relands: Adds constants.GetBuildDirectory() and converts test scripts to use it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/adb_reverse_forwarder.py

Issue 23494039: [android] Relands: Adds constants.GetBuildDirectory() and converts test scripts to use it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix provision_devices.py which never set the build type Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/adb_reverse_forwarder.py

diff --git a/build/android/adb_reverse_forwarder.py b/build/android/adb_reverse_forwarder.py

index ee38332b3c20b85b945c582fdf2d04ce6ff08a4a..de8e6e5f42986af1c830cfbddf65af7ecbf6ec36 100755

--- a/build/android/adb_reverse_forwarder.py

+++ b/build/android/adb_reverse_forwarder.py

@@ -15,7 +15,7 @@ import optparse

import sys

import time

-from pylib import android_commands, forwarder

+from pylib import android_commands, constants, forwarder

from pylib.utils import run_tests_helper

@@ -50,8 +50,9 @@ def main(argv):

sys.exit(1)

adb = android_commands.AndroidCommands(options.device)

+ constants.SetBuildType(options.build_type)

try:

- forwarder.Forwarder.Map(port_pairs, adb, options.build_type)

+ forwarder.Forwarder.Map(port_pairs, adb)

while True:

time.sleep(60)

except KeyboardInterrupt:

« no previous file with comments | « build/android/adb_install_apk.py ('k') | build/android/provision_devices.py » ('j') | no next file with comments »