build/android/pylib/chrome_test_server_spawner.py - Issue 23494039: [android] Relands: Adds constants.GetBuildDirectory() and converts test scripts to use it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/chrome_test_server_spawner.py

Issue 23494039: [android] Relands: Adds constants.GetBuildDirectory() and converts test scripts to use it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix provision_devices.py which never set the build type Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/pylib/chrome_test_server_spawner.py

diff --git a/build/android/pylib/chrome_test_server_spawner.py b/build/android/pylib/chrome_test_server_spawner.py

index b15f2917b1f78bfc3f10f53f8b474c4e8c102647..642e5223eaf6df06575b64f91a25e9e9bf316ac6 100644

--- a/build/android/pylib/chrome_test_server_spawner.py

+++ b/build/android/pylib/chrome_test_server_spawner.py

@@ -249,8 +249,7 @@ class TestServerThread(threading.Thread):

else:

self.is_ready = _CheckPortStatus(self.host_port, True)

if self.is_ready:

- Forwarder.Map([(0, self.host_port)], self.adb, constants.GetBuildType(),

- self.tool)

+ Forwarder.Map([(0, self.host_port)], self.adb, self.tool)

# Check whether the forwarder is ready on the device.

self.is_ready = False

device_port = Forwarder.DevicePortForHostPort(self.host_port)

« no previous file with comments | « build/android/pylib/base/base_test_runner.py ('k') | build/android/pylib/cmd_helper.py » ('j') | no next file with comments »