Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 23466013: Make _output_profile_path a member of ChromeBrowserBackend. (Closed)

Created:
7 years, 3 months ago by achuithb
Modified:
7 years, 3 months ago
Reviewers:
tonyg
CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org
Visibility:
Public.

Description

Make _output_profile_path a member of ChromeBrowserBackend. This removes access of finder_options.output_profile_path from android_browser_backend. BUG=269131 TEST=trybot Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221870

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -12 lines) Patch
M tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py View 2 chunks +8 lines, -7 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py View 1 chunk +2 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py View 2 chunks +4 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/desktop_browser_backend.py View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
achuithb
Tony, what do you think of this?
7 years, 3 months ago (2013-09-06 23:53:33 UTC) #1
tonyg
lgtm
7 years, 3 months ago (2013-09-06 23:57:08 UTC) #2
achuithb
On 2013/09/06 23:57:08, tonyg wrote: > lgtm ty!
7 years, 3 months ago (2013-09-07 00:09:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achuith@chromium.org/23466013/1
7 years, 3 months ago (2013-09-07 00:11:14 UTC) #4
commit-bot: I haz the power
7 years, 3 months ago (2013-09-07 03:06:52 UTC) #5
Message was sent while issue was closed.
Change committed as 221870

Powered by Google App Engine
This is Rietveld 408576698