tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py - Issue 23466013: Make _output_profile_path a member of ChromeBrowserBackend.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py

Issue 23466013: Make _output_profile_path a member of ChromeBrowserBackend. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py ('k') | tools/telemetry/telemetry/core/backends/chrome/desktop_browser_backend.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py

diff --git a/tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py b/tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py

index 876f90992d56afa675ac1167173c5238584be99a..a47192ed2c6fd9f92b14ff7d75a515f11bac9bd7 100644

--- a/tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py

+++ b/tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py

@@ -28,7 +28,8 @@ class ChromeBrowserBackend(browser_backend.BrowserBackend):

once a remote-debugger port has been established."""

# It is OK to have abstract methods. pylint: disable=W0223

- def __init__(self, is_content_shell, supports_extensions, finder_options):

+ def __init__(self, is_content_shell, supports_extensions, finder_options,

+ output_profile_path=None):

super(ChromeBrowserBackend, self).__init__(

is_content_shell=is_content_shell,

supports_extensions=supports_extensions,

@@ -41,6 +42,8 @@ class ChromeBrowserBackend(browser_backend.BrowserBackend):

self._tracing_backend = None

self._system_info_backend = None

+ self._output_profile_path = output_profile_path

self.webpagereplay_local_http_port = util.GetAvailableLocalPort()

self.webpagereplay_local_https_port = util.GetAvailableLocalPort()

self.webpagereplay_remote_http_port = self.webpagereplay_local_http_port