Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py

Issue 23466013: Make _output_profile_path a member of ChromeBrowserBackend. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py
diff --git a/tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py b/tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py
index 3f85d185c663ad29607f5104dcf0b316261672c8..577bb70642c606cf225d2e71f54139c5d104a6f3 100644
--- a/tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py
+++ b/tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py
@@ -147,10 +147,11 @@ class WebviewBackendSettings(AndroidBrowserBackendSettings):
class AndroidBrowserBackend(chrome_browser_backend.ChromeBrowserBackend):
"""The backend for controlling a browser instance running on Android.
"""
- def __init__(self, finder_options, backend_settings):
+ def __init__(self, finder_options, backend_settings, output_profile_path):
super(AndroidBrowserBackend, self).__init__(
is_content_shell=backend_settings.is_content_shell,
- supports_extensions=False, finder_options=finder_options)
+ supports_extensions=False, finder_options=finder_options,
+ output_profile_path=output_profile_path)
if len(finder_options.extensions_to_load) > 0:
raise browser_backend.ExtensionsNotSupportedException(
'Android browser does not support extensions.')
@@ -298,14 +299,14 @@ class AndroidBrowserBackend(chrome_browser_backend.ChromeBrowserBackend):
self._SetCommandLineFile(self._saved_cmdline or '')
self._adb.CloseApplication(self._backend_settings.package)
- if self.finder_options.output_profile_path:
- logging.info("Pulling profile directory from device: '%s'->'%s'." %
- (self._backend_settings.profile_dir,
- self.finder_options.output_profile_path))
+ if self._output_profile_path:
+ logging.info("Pulling profile directory from device: '%s'->'%s'.",
+ self._backend_settings.profile_dir,
+ self._output_profile_path)
# To minimize bandwidth it might be good to look at whether all the data
# pulled down is really needed e.g. .pak files.
self._adb.Pull(self._backend_settings.profile_dir,
- self.finder_options.output_profile_path)
+ self._output_profile_path)
def IsBrowserRunning(self):
pids = self._adb.ExtractPid(self._backend_settings.package)
« no previous file with comments | « no previous file | tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698