Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1105)

Unified Diff: Source/core/html/HTMLSelectElement.cpp

Issue 23464095: WTF::notFound looks too much like a local variable. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/HTMLObjectElement.cpp ('k') | Source/core/html/HTMLTextFormControlElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLSelectElement.cpp
diff --git a/Source/core/html/HTMLSelectElement.cpp b/Source/core/html/HTMLSelectElement.cpp
index 6107fc5c387188fde65951ae1db27526feba289e..5a88a61b5107541d547911987955f805d5e5949e 100644
--- a/Source/core/html/HTMLSelectElement.cpp
+++ b/Source/core/html/HTMLSelectElement.cpp
@@ -955,7 +955,7 @@ size_t HTMLSelectElement::searchOptionsForValue(const String& value, size_t list
if (toHTMLOptionElement(items[i])->value() == value)
return i;
}
- return notFound;
+ return kNotFound;
}
void HTMLSelectElement::restoreFormControlState(const FormControlState& state)
@@ -975,16 +975,16 @@ void HTMLSelectElement::restoreFormControlState(const FormControlState& state)
if (!multiple()) {
size_t foundIndex = searchOptionsForValue(state[0], 0, itemsSize);
- if (foundIndex != notFound)
+ if (foundIndex != kNotFound)
toHTMLOptionElement(items[foundIndex])->setSelectedState(true);
} else {
size_t startIndex = 0;
for (size_t i = 0; i < state.valueSize(); ++i) {
const String& value = state[i];
size_t foundIndex = searchOptionsForValue(value, startIndex, itemsSize);
- if (foundIndex == notFound)
+ if (foundIndex == kNotFound)
foundIndex = searchOptionsForValue(value, 0, startIndex);
- if (foundIndex == notFound)
+ if (foundIndex == kNotFound)
continue;
toHTMLOptionElement(items[foundIndex])->setSelectedState(true);
startIndex = foundIndex + 1;
« no previous file with comments | « Source/core/html/HTMLObjectElement.cpp ('k') | Source/core/html/HTMLTextFormControlElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698