Issue 23464065: [chromedriver] Use data:, instead of about:blank for the start page.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23464065: [chromedriver] Use data:, instead of about:blank for the start page. (Closed)

Created:
7 years, 3 months ago by kkania

Modified:
7 years, 3 months ago

Reviewers:
Ken Kania, chrisgao (Use stgao instead)

CC:
chromium-reviews, kkania, frankf

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

[chromedriver] Use data:, instead of about:blank for the start page. about:blank causes Chrome to focus the url bar, which breaks tests depending on focus. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222563

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -3 lines)			Patch
M	chrome/test/chromedriver/chrome/adb_impl.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/chromedriver/chrome_launcher.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/chromedriver/test/run_py_tests.py	View	2 chunks	+6 lines, -1 line	0 comments	Download

Total messages: 4 (0 generated)

chrisgao (Use stgao instead)

lgtm Never thought of about:blank can cause so many problems...

7 years, 3 months ago (2013-09-11 00:17:10 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kkania@chromium.org/23464065/1

7 years, 3 months ago (2013-09-11 00:39:28 UTC) #3

Message was sent while issue was closed.

Change committed as 222563