Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 23464065: [chromedriver] Use data:, instead of about:blank for the start page. (Closed)

Created:
7 years, 3 months ago by kkania
Modified:
7 years, 3 months ago
CC:
chromium-reviews, kkania, frankf
Visibility:
Public.

Description

[chromedriver] Use data:, instead of about:blank for the start page. about:blank causes Chrome to focus the url bar, which breaks tests depending on focus. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222563

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M chrome/test/chromedriver/chrome/adb_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/chrome_launcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/test/run_py_tests.py View 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
kkania
7 years, 3 months ago (2013-09-11 00:06:16 UTC) #1
chrisgao (Use stgao instead)
lgtm Never thought of about:blank can cause so many problems...
7 years, 3 months ago (2013-09-11 00:17:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kkania@chromium.org/23464065/1
7 years, 3 months ago (2013-09-11 00:39:28 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-09-11 15:26:49 UTC) #4
Message was sent while issue was closed.
Change committed as 222563

Powered by Google App Engine
This is Rietveld 408576698