Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Unified Diff: chrome/test/chromedriver/test/run_py_tests.py

Issue 23464065: [chromedriver] Use data:, instead of about:blank for the start page. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/chromedriver/chrome_launcher.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/test/run_py_tests.py
diff --git a/chrome/test/chromedriver/test/run_py_tests.py b/chrome/test/chromedriver/test/run_py_tests.py
index 70c3b69e242b521cd60b3e47bef0a53936c7e320..936038fc548e94b87917c89267d1c13f0db874b3 100755
--- a/chrome/test/chromedriver/test/run_py_tests.py
+++ b/chrome/test/chromedriver/test/run_py_tests.py
@@ -452,7 +452,7 @@ class ChromeDriverTest(ChromeDriverBaseTest):
self.assertEquals('0123456789+-*/ Hi, there!', value)
def testGetCurrentUrl(self):
- self.assertTrue('about:blank' in self._driver.GetCurrentUrl())
+ self.assertTrue('data:,' in self._driver.GetCurrentUrl())
def testGoBackAndGoForward(self):
self._driver.Load(self.GetHttpUrlForFile('/chromedriver/empty.html'))
@@ -617,6 +617,11 @@ class ChromeDriverTest(ChromeDriverBaseTest):
self._driver.MouseClick(2)
self.assertTrue(self._driver.ExecuteScript('return success'))
+ def testHasFocusOnStartup(self):
+ # Some pages (about:blank) cause Chrome to put the focus in URL bar.
+ # This breaks tests depending on focus.
+ self.assertTrue(self._driver.ExecuteScript('return document.hasFocus()'))
+
class ChromeSwitchesCapabilityTest(ChromeDriverBaseTest):
"""Tests that chromedriver properly processes chromeOptions.args capabilities.
« no previous file with comments | « chrome/test/chromedriver/chrome_launcher.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698