chrome/test/chromedriver/chrome_launcher.cc - Issue 23464065: [chromedriver] Use data:, instead of about:blank for the start page.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/chrome_launcher.cc

Issue 23464065: [chromedriver] Use data:, instead of about:blank for the start page. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/chromedriver/chrome_launcher.cc

diff --git a/chrome/test/chromedriver/chrome_launcher.cc b/chrome/test/chromedriver/chrome_launcher.cc

index 9867d4b23bc9e89078414795c79eb1e0577eb429..f941f78276672e623def8512b1477113905f265b 100644

--- a/chrome/test/chromedriver/chrome_launcher.cc

+++ b/chrome/test/chromedriver/chrome_launcher.cc

@@ -115,7 +115,7 @@ Status PrepareCommandLine(int port,

switches.SetFromSwitches(capabilities.switches);

if (!switches.HasSwitch("user-data-dir")) {

- command.AppendArg("about:blank");

+ command.AppendArg("data:,");

if (!user_data_dir->CreateUniqueTempDir())

return Status(kUnknownError, "cannot create temp dir for user data dir");

switches.SetSwitch("user-data-dir", user_data_dir->path().value());