Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 2346093002: [Telemetry] Add API for updating ts_proxy_server's traffic settings (Closed)

Created:
4 years, 3 months ago by nednguyen
Modified:
4 years, 2 months ago
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org, Kunihiko Sakamoto
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

[Telemetry] Add API for updating ts_proxy_server's traffic settings BUG=catapult:#2584 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/deb46ea2ee48a9c8cd4acd57bd9e33d03f2f6d1b

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -3 lines) Patch
M telemetry/telemetry/core/network_controller.py View 1 1 chunk +5 lines, -0 lines 0 comments Download
M telemetry/telemetry/internal/platform/network_controller_backend.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M telemetry/telemetry/internal/util/ts_proxy_server.py View 1 chunk +6 lines, -0 lines 0 comments Download
M telemetry/telemetry/internal/util/ts_proxy_server_unittest.py View 1 chunk +10 lines, -1 line 0 comments Download
M telemetry/telemetry/page/__init__.py View 4 chunks +10 lines, -2 lines 0 comments Download
M telemetry/telemetry/page/shared_page_state.py View 1 2 chunks +6 lines, -0 lines 0 comments Download
A telemetry/telemetry/page/traffic_setting.py View 1 chunk +12 lines, -0 lines 0 comments Download
M telemetry/telemetry/testing/fakes/__init__.py View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 26 (14 generated)
nednguyen
4 years, 3 months ago (2016-09-16 18:58:40 UTC) #4
Pat Meenan
LGTM for the parts that interact with tsproxy
4 years, 3 months ago (2016-09-16 21:02:01 UTC) #7
nednguyen
On 2016/09/16 21:02:01, Pat Meenan wrote: > LGTM for the parts that interact with tsproxy ...
4 years, 2 months ago (2016-09-27 20:46:35 UTC) #8
kouhei (in TOK)
lgtm
4 years, 2 months ago (2016-09-28 04:09:44 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2346093002/1
4 years, 2 months ago (2016-09-28 13:44:33 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: Catapult Linux Tryserver on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Linux%20Tryserver/builds/5064) Catapult Mac ...
4 years, 2 months ago (2016-09-28 13:45:23 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2346093002/20001
4 years, 2 months ago (2016-09-28 13:56:36 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: Catapult Windows Tryserver on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Windows%20Tryserver/builds/4923)
4 years, 2 months ago (2016-09-28 15:17:20 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2346093002/20001
4 years, 2 months ago (2016-09-28 15:31:30 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: Catapult Windows Tryserver on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Windows%20Tryserver/builds/4925)
4 years, 2 months ago (2016-09-28 16:54:20 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2346093002/20001
4 years, 2 months ago (2016-09-28 17:00:10 UTC) #24
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 17:22:42 UTC) #26
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698