Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Unified Diff: telemetry/telemetry/page/shared_page_state.py

Issue 2346093002: [Telemetry] Add API for updating ts_proxy_server's traffic settings (Closed)
Patch Set: Rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « telemetry/telemetry/page/__init__.py ('k') | telemetry/telemetry/page/traffic_setting.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: telemetry/telemetry/page/shared_page_state.py
diff --git a/telemetry/telemetry/page/shared_page_state.py b/telemetry/telemetry/page/shared_page_state.py
index b30aad72cffce3989ef0d458c888349dec4cbad7..c6723784519446055f181b0189fd78bfbb933263 100644
--- a/telemetry/telemetry/page/shared_page_state.py
+++ b/telemetry/telemetry/page/shared_page_state.py
@@ -16,6 +16,7 @@ from telemetry.internal.platform.profiler import profiler_finder
from telemetry.internal.util import exception_formatter
from telemetry.internal.util import file_handle
from telemetry.page import cache_temperature
+from telemetry.page import traffic_setting
from telemetry.page import legacy_page_test
from telemetry import story
from telemetry.util import screenshot
@@ -246,8 +247,13 @@ class SharedPageState(story.SharedState):
if started_browser:
self.browser.tabs[0].WaitForDocumentReadyStateToBeComplete()
+ # Reset traffic shaping to speed up cache temperature setup.
+ self.platform.network_controller.UpdateTrafficSettings(0, 0, 0)
cache_temperature.EnsurePageCacheTemperature(
self._current_page, self.browser, self._previous_page)
+ if self._current_page.traffic_setting != traffic_setting.NONE:
+ # TODO(kouhei): fill in appropriate traffic shaping data.
+ raise NotImplementedError()
# Start profiling if needed.
if self._finder_options.profiler:
« no previous file with comments | « telemetry/telemetry/page/__init__.py ('k') | telemetry/telemetry/page/traffic_setting.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698