Profiler.is_supported takes browser_type instead of options.

Profiler.is_supported takes browser_type instead of options.

BUG=269131
TEST=trybot, manual

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222265

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222503

[achuithb, 2013-09-09 20:49:26]

Tony, please take a look.

[tonyg, 2013-09-09 21:50:41]

https://codereview.chromium.org/23458037/diff/1/tools/telemetry/telemetry/cor...
File tools/telemetry/telemetry/core/platform/profiler/profiler_finder.py
(right):

https://codereview.chromium.org/23458037/diff/1/tools/telemetry/telemetry/cor...
tools/telemetry/telemetry/core/platform/profiler/profiler_finder.py:27: if
p.is_supported(browser_type='any')])
Did this work previous if I did this?
run_measurement --browser=android-content-shell --profiler=list

If so, is there an easy way to preserve that?

[achuithb, 2013-09-09 21:57:47]

https://codereview.chromium.org/23458037/diff/1/tools/telemetry/telemetry/cor...
File tools/telemetry/telemetry/core/platform/profiler/profiler_finder.py
(right):

https://codereview.chromium.org/23458037/diff/1/tools/telemetry/telemetry/cor...
tools/telemetry/telemetry/core/platform/profiler/profiler_finder.py:27: if
p.is_supported(browser_type='any')])
On 2013/09/09 21:50:41, tonyg wrote:
> Did this work previous if I did this?
> run_measurement --browser=android-content-shell --profiler=list
> 
> If so, is there an easy way to preserve that?

As far as I can tell, GetAllAvailableProfilers is only ever called with
options=None:
https://code.google.com/p/chromium/codesearch#search/&q=GetAllAvailableProfil...

[achuithb, 2013-09-09 21:59:44]

On 2013/09/09 21:57:47, achuith.bhandarkar wrote:
>
https://codereview.chromium.org/23458037/diff/1/tools/telemetry/telemetry/cor...
> File tools/telemetry/telemetry/core/platform/profiler/profiler_finder.py
> (right):
> 
>
https://codereview.chromium.org/23458037/diff/1/tools/telemetry/telemetry/cor...
> tools/telemetry/telemetry/core/platform/profiler/profiler_finder.py:27: if
> p.is_supported(browser_type='any')])
> On 2013/09/09 21:50:41, tonyg wrote:
> > Did this work previous if I did this?
> > run_measurement --browser=android-content-shell --profiler=list
> > 
> > If so, is there an easy way to preserve that?
> 
> As far as I can tell, GetAllAvailableProfilers is only ever called with
> options=None:
>
https://code.google.com/p/chromium/codesearch#search/&q=GetAllAvailableProfil...

Interesting url encode fail, this link hopefully works
https://code.google.com/p/chromium/codesearch#search/&q=GetAllAvailableProfil...

[tonyg, 2013-09-10 00:45:14]

You are right. LGTM

[commit-bot: I haz the power, 2013-09-10 00:52:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/achuith@chromium.org/23458037/1

[commit-bot: I haz the power, 2013-09-10 01:23:37]

Sorry for I got bad news for ya.
Compile failed with a clobber build on mac_rel.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-09-10 01:31:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/achuith@chromium.org/23458037/1

[commit-bot: I haz the power, 2013-09-10 01:43:09]

Sorry for I got bad news for ya.
Compile failed with a clobber build on mac_rel.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-09-10 01:54:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/achuith@chromium.org/23458037/1

[commit-bot: I haz the power, 2013-09-10 02:05:10]

Sorry for I got bad news for ya.
Compile failed with a clobber build on mac_rel.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-09-10 06:55:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/achuith@chromium.org/23458037/1

[commit-bot: I haz the power, 2013-09-10 09:03:30]

Retried try job too often on mac_rel for step(s) telemetry_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2013-09-10 11:07:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/achuith@chromium.org/23458037/21001

[commit-bot: I haz the power, 2013-09-10 16:02:27]

Change committed as 222265

[achuithb, 2013-09-10 21:59:05]

Tony, only loading_profile.py has changed. Please take a look.

[tonyg, 2013-09-10 22:07:32]

lgtm

[achuithb, 2013-09-10 22:08:11]

On 2013/09/10 22:07:32, tonyg wrote:
> lgtm

ty!

[commit-bot: I haz the power, 2013-09-10 22:15:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/achuith@chromium.org/23458037/56001

[commit-bot: I haz the power, 2013-09-11 12:09:52]

Change committed as 222503