tools/telemetry/telemetry/core/platform/profiler/tcpdump_profiler.py - Issue 23458037: Profiler.is_supported takes browser_type instead of options.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/platform/profiler/tcpdump_profiler.py

Issue 23458037: Profiler.is_supported takes browser_type instead of options. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix loading_profile.py Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/platform/profiler/tcmalloc_heap_profiler.py ('k') | tools/telemetry/telemetry/core/platform/profiler/trace_profiler.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/platform/profiler/tcpdump_profiler.py

diff --git a/tools/telemetry/telemetry/core/platform/profiler/tcpdump_profiler.py b/tools/telemetry/telemetry/core/platform/profiler/tcpdump_profiler.py

index 97e2ac5681fec1b30f7ded03a69eb3975d55b8ce..53bdf1730e0bf5c5246a5f35940d1b11709e8ff0 100644

--- a/tools/telemetry/telemetry/core/platform/profiler/tcpdump_profiler.py

+++ b/tools/telemetry/telemetry/core/platform/profiler/tcpdump_profiler.py

@@ -98,14 +98,14 @@ class TCPDumpProfiler(profiler.Profiler):

return 'tcpdump'

@classmethod

- def is_supported(cls, options):

- if options and options.browser_type.startswith('cros'):

+ def is_supported(cls, browser_type):

+ if browser_type.startswith('cros'):

return False

if sys.platform.startswith('linux'):

return True

- if not options:

+ if browser_type == 'any':

return android_browser_finder.CanFindAvailableBrowsers()

- return options.browser_type.startswith('android')

+ return browser_type.startswith('android')

def CollectProfile(self):

self._platform_profiler.CollectProfile()