tools/telemetry/telemetry/core/platform/profiler/vtune_profiler.py - Issue 23458037: Profiler.is_supported takes browser_type instead of options.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/platform/profiler/vtune_profiler.py

Issue 23458037: Profiler.is_supported takes browser_type instead of options. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix loading_profile.py Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/telemetry/telemetry/core/platform/profiler/vtune_profiler.py

diff --git a/tools/telemetry/telemetry/core/platform/profiler/vtune_profiler.py b/tools/telemetry/telemetry/core/platform/profiler/vtune_profiler.py

index 746349dd70e5e8d16231f5fa5db13360e2bf41e7..850f3a28e0bc1ae5a3a12b72f2f4e27c42d9cd34 100644

--- a/tools/telemetry/telemetry/core/platform/profiler/vtune_profiler.py

+++ b/tools/telemetry/telemetry/core/platform/profiler/vtune_profiler.py

@@ -84,11 +84,11 @@ class VTuneProfiler(profiler.Profiler):

return 'vtune'

@classmethod

- def is_supported(cls, options):

+ def is_supported(cls, browser_type):

if sys.platform != 'linux2':

return False

- if options and (options.browser_type.startswith('android')

- or options.browser_type.startswith('cros')):

+ if (browser_type.startswith('android') or

+ browser_type.startswith('cros')):

return False

try:

return not subprocess.Popen(['amplxe-cl', '-version'],

« no previous file with comments | « tools/telemetry/telemetry/core/platform/profiler/trace_profiler.py ('k') | no next file » | no next file with comments »