cc: Tell the LayerTreeHost that the filter context is needed.

cc: Tell the LayerTreeHost that the filter context is needed.

Delegated frames may contain an offscreen filter. If they do, then the
LayerTreeHost needs to know about it so it can create an offscreen
context.

R=piman
BUG=287870
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222169

[piman, 2013-09-09 19:26:45]

LGTM+nit

https://codereview.chromium.org/23451023/diff/11001/cc/layers/delegated_rende...
File cc/layers/delegated_renderer_layer.cc (right):

https://codereview.chromium.org/23451023/diff/11001/cc/layers/delegated_rende...
cc/layers/delegated_renderer_layer.cc:111: for (size_t i = 0;
nit: could we skip this once we have set needs_filter_context_ to true? No need
to go over the passes in this case. WDYT?

[danakj, 2013-09-09 19:27:26]

https://codereview.chromium.org/23451023/diff/11001/cc/layers/delegated_rende...
File cc/layers/delegated_renderer_layer.cc (right):

https://codereview.chromium.org/23451023/diff/11001/cc/layers/delegated_rende...
cc/layers/delegated_renderer_layer.cc:111: for (size_t i = 0;
On 2013/09/09 19:26:45, piman wrote:
> nit: could we skip this once we have set needs_filter_context_ to true? No
need
> to go over the passes in this case. WDYT?

That's in the condition on the next line, which also handles early-out once it
becomes set mid-traversal.

Is that what you mean?

[commit-bot: I haz the power, 2013-09-09 21:06:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/23451023/11001

[piman, 2013-09-09 21:07:18]

On Mon, Sep 9, 2013 at 12:27 PM, <danakj@chromium.org> wrote:

>
> https://codereview.chromium.**org/23451023/diff/11001/cc/**
>
layers/delegated_renderer_**layer.cc<https://codereview.chromium.org/23451023/diff/11001/cc/layers/delegated_renderer_layer.cc>
> File cc/layers/delegated_renderer_**layer.cc (right):
>
> https://codereview.chromium.**org/23451023/diff/11001/cc/**
>
layers/delegated_renderer_**layer.cc#newcode111<https://codereview.chromium.org/23451023/diff/11001/cc/layers/delegated_renderer_layer.cc#newcode111>
> cc/layers/delegated_renderer_**layer.cc:111: for (size_t i = 0;
> On 2013/09/09 19:26:45, piman wrote:
>
>> nit: could we skip this once we have set needs_filter_context_ to
>>
> true? No need
>
>> to go over the passes in this case. WDYT?
>>
>
> That's in the condition on the next line, which also handles early-out
> once it becomes set mid-traversal.
>
> Is that what you mean?
>

Oh, you're right, I missed that. LGTM.

>
>
https://codereview.chromium.**org/23451023/<https://codereview.chromium.org/2...
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2013-09-09 22:21:11]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win_x64_rel.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_re...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-09-09 22:29:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/23451023/6007

[commit-bot: I haz the power, 2013-09-10 01:38:22]

Change committed as 222169