Update tests to check fields directly.

Update tests to check fields directly.

Also moves the count in to the Action class so the count is accessible.

BUG=255728
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221546

[karenlees, 2013-08-29 22:47:48]

I wasn't sure if you wanted the count to default to 0 or 1 for the other
policies.  I don't test the count field in the FullStreamUI tests but could add.

[felt, 2013-08-31 01:32:22]

On 2013/08/29 22:47:48, karenlees wrote:
> I wasn't sure if you wanted the count to default to 0 or 1 for the other
> policies.  I don't test the count field in the FullStreamUI tests but could
add.

Defaulting to 0 works for me. I assume the only case where we'd actually get a 0
from a log is when it's non-counted, so that allows the watchdog app to know not
to treat it like a counted action (even though this case will happen rarely,
since we assume most people will run with the counting policy).

lgtm

[commit-bot: I haz the power, 2013-09-03 15:51:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/karenlees@chromium.org/23449016/1

[commit-bot: I haz the power, 2013-09-03 16:19:05]

Sorry for I got bad news for ya.
Compile failed with a clobber build on android_clang_dbg.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_cl...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[karenlees, 2013-09-03 16:33:20]

On 2013/09/03 16:19:05, I haz the power (commit-bot) wrote:
> Sorry for I got bad news for ya.
> Compile failed with a clobber build on android_clang_dbg.
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_cl...
> Your code is likely broken or HEAD is junk. Please ensure your
> code is not broken then alert the build sheriffs.
> Look at the try server FAQ for more details.

Damit:
../../chrome/browser/extensions/activity_log/activity_actions.cc:234:23: error:
adding 'const int' to a string does not append to the string
[-Werror,-Wstring-plus-int]
  result += " COUNT=" + count_;
            ~~~~~~~~~~^~~~~~~~

Uploading fix shortly.

[karenlees, 2013-09-03 17:03:33]

On 2013/09/03 16:33:20, karenlees wrote:
> On 2013/09/03 16:19:05, I haz the power (commit-bot) wrote:
> > Sorry for I got bad news for ya.
> > Compile failed with a clobber build on android_clang_dbg.
> >
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_cl...
> > Your code is likely broken or HEAD is junk. Please ensure your
> > code is not broken then alert the build sheriffs.
> > Look at the try server FAQ for more details.
> 
> Damit:
> ../../chrome/browser/extensions/activity_log/activity_actions.cc:234:23:
error:
> adding 'const int' to a string does not append to the string
> [-Werror,-Wstring-plus-int]
>   result += " COUNT=" + count_;
>             ~~~~~~~~~~^~~~~~~~
> 
> Uploading fix shortly.

Trying again.

[commit-bot: I haz the power, 2013-09-03 17:04:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/karenlees@chromium.org/23449016/28001

[commit-bot: I haz the power, 2013-09-03 18:08:03]

Retried try job too often on linux_rel for step(s) unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[karenlees, 2013-09-03 19:08:09]

On 2013/09/03 18:08:03, I haz the power (commit-bot) wrote:
> Retried try job too often on linux_rel for step(s) unit_tests
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

It was failing because of some other tests that used the PrintForDebug method
and the output had changed because it now got the "COUNT=0" for the fullstream
policy.  I've added all the tests that use PrintForDebug to the CL and updated
to check fields directly.  PTAL.

[felt, 2013-09-04 14:06:00]

On 2013/09/03 19:08:09, karenlees wrote:
> On 2013/09/03 18:08:03, I haz the power (commit-bot) wrote:
> > Retried try job too often on linux_rel for step(s) unit_tests
> >
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...
> 
> It was failing because of some other tests that used the PrintForDebug method
> and the output had changed because it now got the "COUNT=0" for the fullstream
> policy.  I've added all the tests that use PrintForDebug to the CL and updated
> to check fields directly.  PTAL.

Thanks for the update, lgtm.

[commit-bot: I haz the power, 2013-09-04 16:42:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/karenlees@chromium.org/23449016/47001

[commit-bot: I haz the power, 2013-09-05 01:54:48]

Retried try job too often on win7_aura for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...

[karenlees, 2013-09-05 02:12:36]

On 2013/09/05 01:54:48, I haz the power (commit-bot) wrote:
> Retried try job too often on win7_aura for step(s) browser_tests
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...

Not sure what's up with the CQ today.  299 tests are broken in win7_aura because
of timeouts.  

Michael- if you want to go ahead and submit your CL which touches these tests,
I'll sync with that and try again another day. I think your CL is more important
to get in this week than the test updates.

[commit-bot: I haz the power, 2013-09-05 17:42:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/karenlees@chromium.org/23449016/46001

[commit-bot: I haz the power, 2013-09-05 23:44:57]

Change committed as 221546