Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1581)

Unified Diff: chrome/browser/extensions/activity_log/activity_log_unittest.cc

Issue 23449016: Update tests to check fields directly. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/activity_log/activity_log_unittest.cc
diff --git a/chrome/browser/extensions/activity_log/activity_log_unittest.cc b/chrome/browser/extensions/activity_log/activity_log_unittest.cc
index 757d4c28e4331f8c7ebc85c066698f4509de52bc..85e7f6e80bd6f614cd868fdd3aa0bfa45d1f5c64 100644
--- a/chrome/browser/extensions/activity_log/activity_log_unittest.cc
+++ b/chrome/browser/extensions/activity_log/activity_log_unittest.cc
@@ -90,11 +90,17 @@ class ActivityLogTest : public ChromeRenderViewHostTestHarness {
scoped_ptr<std::vector<scoped_refptr<Action> > > i) {
ASSERT_EQ(1U, i->size());
scoped_refptr<Action> last = i->front();
- std::string args =
- "ID=odlameecjipmbmbejkplpemijjgpljce CATEGORY=content_script API= "
- "ARGS=[\"script\"] PAGE_URL=http://www.google.com/ "
- "OTHER={\"prerender\":true}";
- ASSERT_EQ(args, last->PrintForDebug());
+
+ ASSERT_EQ("odlameecjipmbmbejkplpemijjgpljce", last->extension_id());
+ ASSERT_EQ(Action::ACTION_CONTENT_SCRIPT, last->action_type());
+ ASSERT_EQ("[\"script\"]",
+ ActivityLogPolicy::Util::Serialize(last->args()));
+ ASSERT_EQ("http://www.google.com/", last->SerializePageUrl());
+ ASSERT_EQ("{\"prerender\":true}",
+ ActivityLogPolicy::Util::Serialize(last->other()));
+ ASSERT_EQ("", last->api_name());
+ ASSERT_EQ("", last->page_title());
+ ASSERT_EQ("", last->SerializeArgUrl());
}
ExtensionService* extension_service_;

Powered by Google App Engine
This is Rietveld 408576698