Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5760)

Unified Diff: chrome/browser/extensions/activity_log/activity_log_browsertest.cc

Issue 23449016: Update tests to check fields directly. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/activity_log/activity_log_browsertest.cc
diff --git a/chrome/browser/extensions/activity_log/activity_log_browsertest.cc b/chrome/browser/extensions/activity_log/activity_log_browsertest.cc
index 2c73cda35e166165b5955f9e8b1d769c9577b68f..27c92252c9680da60e18574f0c80a765e277c4b4 100644
--- a/chrome/browser/extensions/activity_log/activity_log_browsertest.cc
+++ b/chrome/browser/extensions/activity_log/activity_log_browsertest.cc
@@ -44,13 +44,20 @@ class ActivityLogPrerenderTest : public ExtensionApiTest {
ASSERT_TRUE(i->size());
scoped_refptr<Action> last = i->front();
+ ASSERT_EQ(extension_id, last->extension_id());
ASSERT_EQ(Action::ACTION_CONTENT_SCRIPT, last->action_type());
ASSERT_EQ("[\"/google_cs.js\"]",
ActivityLogPolicy::Util::Serialize(last->args()));
- ASSERT_EQ(base::StringPrintf("http://www.google.com.bo:%d/test.html", port),
- last->page_url().spec());
+ ASSERT_EQ(
+ base::StringPrintf("http://www.google.com.bo:%d/test.html", port),
+ last->SerializePageUrl());
+ ASSERT_EQ(
+ base::StringPrintf("www.google.com.bo:%d/test.html", port),
+ last->page_title());
ASSERT_EQ("{\"prerender\":true}",
ActivityLogPolicy::Util::Serialize(last->other()));
+ ASSERT_EQ("", last->api_name());
+ ASSERT_EQ("", last->SerializeArgUrl());
}
};

Powered by Google App Engine
This is Rietveld 408576698