Implement closurization of regular methods in ObjectMirror.getField in the VM.

Implement closurization of regular methods in ObjectMirror.getField in the VM.

BUG=http://dartbug.com/13001
BUG=http://dartbug.com/13002
R=asiva@google.com

Committed: https://code.google.com/p/dart/source/detail?r=27916

[rmacnak, 2013-09-17 00:19:13]

+Siva, Gilad

Refactored creation of implicit static closures to share implementation between
mirrors and compiler.

(Continuation of https://codereview.chromium.org/23909002/ in a new CL because
of updated the old one repeated failure re missing base files.)

[gbracha, 2013-09-17 00:22:44]

On 2013/09/17 00:19:13, Ryan Macnak wrote:
> +Siva, Gilad
> 
> Refactored creation of implicit static closures to share implementation
between
> mirrors and compiler.
> 
> (Continuation of https://codereview.chromium.org/23909002/ in a new CL because
> of updated the old one repeated failure re missing base files.)

Spec changes look good .

[Michael Lippautz (Google), 2013-09-23 18:53:40]

Ping. ClosureMirror.findInContext CL depends on this.

[siva, 2013-09-25 20:17:56]

LGTM with some comments.

https://chromiumcodereview.appspot.com/23441073/diff/9001/runtime/lib/mirrors.cc
File runtime/lib/mirrors.cc (right):

https://chromiumcodereview.appspot.com/23441073/diff/9001/runtime/lib/mirrors...
runtime/lib/mirrors.cc:1007: 
extra blank line.

https://chromiumcodereview.appspot.com/23441073/diff/9001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://chromiumcodereview.appspot.com/23441073/diff/9001/runtime/vm/object.c...
runtime/vm/object.cc:4933: if (closure.IsNull()) {
if (implicit_static_closure() != Instance::null()) {
  ....
  ....
  const Instance& closure = Instance::Handle(Closure::New(...));
  set_implicit_static_closure(closure);
}
return implicit_static_closure();

https://chromiumcodereview.appspot.com/23441073/diff/9001/runtime/vm/resolver.cc
File runtime/vm/resolver.cc (right):

https://chromiumcodereview.appspot.com/23441073/diff/9001/runtime/vm/resolver...
runtime/vm/resolver.cc:174: cls = cls.SuperClass();
Can we change the loop such that cls.cls.SuperClass() is not done once the
function is found i.e non null.

while (!cls.IsNull()) {
  function ^= ....;
  if (!function.IsNull()) {
    return function.raw();
  }
  if (is_getter) {
    function ^= .....
    if (!function.IsNull()) {
      function ^= ...
      return function.raw();
    }
    .....
  }
  cls = cls.SuperClass(); 
}
return Function::null();

[rmacnak, 2013-09-25 21:41:34]

https://chromiumcodereview.appspot.com/23441073/diff/9001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://chromiumcodereview.appspot.com/23441073/diff/9001/runtime/vm/object.c...
runtime/vm/object.cc:4933: if (closure.IsNull()) {
On 2013/09/25 20:17:57, siva wrote:
> if (implicit_static_closure() != Instance::null()) {
>   ....
>   ....
>   const Instance& closure = Instance::Handle(Closure::New(...));
>   set_implicit_static_closure(closure);
> }
> return implicit_static_closure();

Done.

https://chromiumcodereview.appspot.com/23441073/diff/9001/runtime/vm/resolver.cc
File runtime/vm/resolver.cc (right):

https://chromiumcodereview.appspot.com/23441073/diff/9001/runtime/vm/resolver...
runtime/vm/resolver.cc:174: cls = cls.SuperClass();
On 2013/09/25 20:17:57, siva wrote:
> Can we change the loop such that cls.cls.SuperClass() is not done once the
> function is found i.e non null.
> 
> while (!cls.IsNull()) {
>   function ^= ....;
>   if (!function.IsNull()) {
>     return function.raw();
>   }
>   if (is_getter) {
>     function ^= .....
>     if (!function.IsNull()) {
>       function ^= ...
>       return function.raw();
>     }
>     .....
>   }
>   cls = cls.SuperClass(); 
> }
> return Function::null();

Done, and likewise to ResolveDynamicAnyArgs.

[rmacnak, 2013-09-25 21:42:22]

Committed patchset #3 manually as r27916 (presubmit successful).