Implement closurization of regular methods in ObjectMirror.getField in the VM.

runtime/vm/resolver.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/resolver.h"
 
 #include "vm/dart_entry.h"
 #include "vm/flags.h"
 #include "vm/isolate.h"
 #include "vm/object.h"
@@ skipping 120 matching lines @@
         function ^= CreateMethodExtractor(function_name, function);
       }
     }
 
     cls = cls.SuperClass();
   }
   return function.raw();
 }
 
 
+// TODO(13355): Remove.
+RawFunction* Resolver::ResolveDynamicAnyArgsAllowPrivate(
+    const Class& receiver_class,
+    const String& function_name) {
+  Class& cls = Class::Handle(receiver_class.raw());
+  if (FLAG_trace_resolving) {
+    OS::Print("ResolveDynamic '%s' for class %s\n",
+              function_name.ToCString(),
+              String::Handle(cls.Name()).ToCString());
+  }
+
+  const bool is_getter = Field::IsGetterName(function_name);
+  String& field_name = String::Handle();
+  if (is_getter) {
+    field_name ^= Field::NameFromGetter(function_name);
+  }
+
+  // Now look for an instance function whose name matches function_name
+  // in the class.
+  Function& function = Function::Handle();
+  while (function.IsNull() && !cls.IsNull()) {
+    function ^= cls.LookupDynamicFunctionAllowPrivate(function_name);
+
+    // Getter invocation might actually be a method extraction.
+    if (is_getter && function.IsNull()) {
+      function ^= cls.LookupDynamicFunctionAllowPrivate(field_name);
+      if (!function.IsNull()) {
+        // We were looking for the getter but found a method with the same name.
+        // Create a method extractor and return it.
+        function ^= CreateMethodExtractor(function_name, function);
+      }
+    }
+
+    cls = cls.SuperClass();

[siva, 2013/09/25 20:17:57]

Can we change the loop such that cls.cls.SuperClass() is not done once the
function is found i.e non null.

while (!cls.IsNull()) {
  function ^= ....;
  if (!function.IsNull()) {
    return function.raw();
  }
  if (is_getter) {
    function ^= .....
    if (!function.IsNull()) {
      function ^= ...
      return function.raw();
    }
    .....
  }
  cls = cls.SuperClass(); 
}
return Function::null();

[rmacnak, 2013/09/25 21:41:35]

Done, and likewise to ResolveDynamicAnyArgs.

+  }
+  return function.raw();
+}
+
+
 RawFunction* Resolver::ResolveStatic(const Library& library,
                                      const String& class_name,
                                      const String& function_name,
                                      intptr_t num_arguments,
                                      const Array& argument_names,
                                      StaticResolveType resolve_type) {
   ASSERT(!library.IsNull());
   Function& function = Function::Handle();
   if (class_name.IsNull() || (class_name.Length() == 0)) {
     // Check if we are referring to a top level function.
@@ skipping 91 matching lines @@
       OS::Print("ResolveStatic error '%s': %s.\n",
                 function_name.ToCString(),
                 error_message.ToCString());
     }
     return Function::null();
   }
   return function.raw();
 }
 
 }  // namespace dart