Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 23361014: Never clear debug-stub call ICs. Make a clear distinction between is_debug_stub (Closed)

Created:
7 years, 4 months ago by Toon Verwaest
Modified:
7 years, 4 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Never clear debug-stub call ICs. Make a clear distinction between is_debug_stub used everywhere but the debugger, and IsDebugBreak, used by the debugger. R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16269

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -20 lines) Patch
M src/debug.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/liveedit.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 1 chunk +1 line, -1 line 0 comments Download
M src/objects-inl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/runtime.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime.cc View 1 chunk +8 lines, -0 lines 0 comments Download
A + test/mjsunit/regress/debug-prepare-step-in.js View 2 chunks +19 lines, -14 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL
7 years, 4 months ago (2013-08-22 12:09:54 UTC) #1
Yang
On 2013/08/22 12:09:54, Toon Verwaest wrote: > PTAL lgtm.
7 years, 4 months ago (2013-08-22 12:15:04 UTC) #2
Toon Verwaest
7 years, 4 months ago (2013-08-22 12:16:12 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r16269.

Powered by Google App Engine
This is Rietveld 408576698