Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Side by Side Diff: src/debug.cc

Issue 23361014: Never clear debug-stub call ICs. Make a clear distinction between is_debug_stub (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/ic.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1609 matching lines...) Expand 10 before | Expand all | Expand 10 after
1620 1620
1621 // No step next action - don't continue. 1621 // No step next action - don't continue.
1622 return false; 1622 return false;
1623 } 1623 }
1624 1624
1625 1625
1626 // Check whether the code object at the specified address is a debug break code 1626 // Check whether the code object at the specified address is a debug break code
1627 // object. 1627 // object.
1628 bool Debug::IsDebugBreak(Address addr) { 1628 bool Debug::IsDebugBreak(Address addr) {
1629 Code* code = Code::GetCodeFromTargetAddress(addr); 1629 Code* code = Code::GetCodeFromTargetAddress(addr);
1630 return code->is_debug_break(); 1630 return code->is_debug_stub() && code->extra_ic_state() == DEBUG_BREAK;
1631 } 1631 }
1632 1632
1633 1633
1634 // Check whether a code stub with the specified major key is a possible break 1634 // Check whether a code stub with the specified major key is a possible break
1635 // point location when looking for source break locations. 1635 // point location when looking for source break locations.
1636 bool Debug::IsSourceBreakStub(Code* code) { 1636 bool Debug::IsSourceBreakStub(Code* code) {
1637 CodeStub::Major major_key = CodeStub::GetMajorKey(code); 1637 CodeStub::Major major_key = CodeStub::GetMajorKey(code);
1638 return major_key == CodeStub::CallFunction; 1638 return major_key == CodeStub::CallFunction;
1639 } 1639 }
1640 1640
(...skipping 2224 matching lines...) Expand 10 before | Expand all | Expand 10 after
3865 { 3865 {
3866 Locker locker(reinterpret_cast<v8::Isolate*>(isolate_)); 3866 Locker locker(reinterpret_cast<v8::Isolate*>(isolate_));
3867 isolate_->debugger()->CallMessageDispatchHandler(); 3867 isolate_->debugger()->CallMessageDispatchHandler();
3868 } 3868 }
3869 } 3869 }
3870 } 3870 }
3871 3871
3872 #endif // ENABLE_DEBUGGER_SUPPORT 3872 #endif // ENABLE_DEBUGGER_SUPPORT
3873 3873
3874 } } // namespace v8::internal 3874 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/ic.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698