Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: src/liveedit.cc

Issue 23361014: Never clear debug-stub call ICs. Make a clear distinction between is_debug_stub (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ic.cc ('k') | src/objects.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1673 matching lines...) Expand 10 before | Expand all | Expand 10 after
1684 StackFrame* top_frame = frames[top_frame_index]; 1684 StackFrame* top_frame = frames[top_frame_index];
1685 StackFrame* bottom_js_frame = frames[bottom_js_frame_index]; 1685 StackFrame* bottom_js_frame = frames[bottom_js_frame_index];
1686 1686
1687 ASSERT(bottom_js_frame->is_java_script()); 1687 ASSERT(bottom_js_frame->is_java_script());
1688 1688
1689 // Check the nature of the top frame. 1689 // Check the nature of the top frame.
1690 Isolate* isolate = Isolate::Current(); 1690 Isolate* isolate = Isolate::Current();
1691 Code* pre_top_frame_code = pre_top_frame->LookupCode(); 1691 Code* pre_top_frame_code = pre_top_frame->LookupCode();
1692 bool frame_has_padding; 1692 bool frame_has_padding;
1693 if (pre_top_frame_code->is_inline_cache_stub() && 1693 if (pre_top_frame_code->is_inline_cache_stub() &&
1694 pre_top_frame_code->is_debug_break()) { 1694 pre_top_frame_code->is_debug_stub()) {
1695 // OK, we can drop inline cache calls. 1695 // OK, we can drop inline cache calls.
1696 *mode = Debug::FRAME_DROPPED_IN_IC_CALL; 1696 *mode = Debug::FRAME_DROPPED_IN_IC_CALL;
1697 frame_has_padding = Debug::FramePaddingLayout::kIsSupported; 1697 frame_has_padding = Debug::FramePaddingLayout::kIsSupported;
1698 } else if (pre_top_frame_code == 1698 } else if (pre_top_frame_code ==
1699 isolate->debug()->debug_break_slot()) { 1699 isolate->debug()->debug_break_slot()) {
1700 // OK, we can drop debug break slot. 1700 // OK, we can drop debug break slot.
1701 *mode = Debug::FRAME_DROPPED_IN_DEBUG_SLOT_CALL; 1701 *mode = Debug::FRAME_DROPPED_IN_DEBUG_SLOT_CALL;
1702 frame_has_padding = Debug::FramePaddingLayout::kIsSupported; 1702 frame_has_padding = Debug::FramePaddingLayout::kIsSupported;
1703 } else if (pre_top_frame_code == 1703 } else if (pre_top_frame_code ==
1704 isolate->builtins()->builtin( 1704 isolate->builtins()->builtin(
(...skipping 423 matching lines...) Expand 10 before | Expand all | Expand 10 after
2128 2128
2129 bool LiveEditFunctionTracker::IsActive(Isolate* isolate) { 2129 bool LiveEditFunctionTracker::IsActive(Isolate* isolate) {
2130 return false; 2130 return false;
2131 } 2131 }
2132 2132
2133 #endif // ENABLE_DEBUGGER_SUPPORT 2133 #endif // ENABLE_DEBUGGER_SUPPORT
2134 2134
2135 2135
2136 2136
2137 } } // namespace v8::internal 2137 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/ic.cc ('k') | src/objects.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698