Don't show the search-by-image menu item when the image is blocked (no image pixel data)

Don't show the search-by-image menu item when the image does not have contents.

BUG=272076
TEST=None

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=219376

[Johnny(Jianning) Ding, 2013-08-20 03:15:30]

On 2013/08/14 21:25:44, Johnny(Jianning) Ding wrote:

ping.

[Peter Kasting, 2013-08-20 18:33:15]

LGTM

https://codereview.chromium.org/23200006/diff/6001/chrome/browser/tab_content...
File chrome/browser/tab_contents/render_view_context_menu.cc (right):

https://codereview.chromium.org/23200006/diff/6001/chrome/browser/tab_content...
chrome/browser/tab_contents/render_view_context_menu.cc:1800: NavigationEntry*
nav_entry = controller->GetActiveEntry();
Is this change correct?  It looks surprising to me.

https://codereview.chromium.org/23200006/diff/6001/content/public/common/cont...
File content/public/common/context_menu_params.h (right):

https://codereview.chromium.org/23200006/diff/6001/content/public/common/cont...
content/public/common/context_menu_params.h:77: // contents.
Nit: non-empty contents?

[Peter Kasting, 2013-08-20 18:34:11]

On 2013/08/20 18:33:15, Peter Kasting wrote:
> LGTM

I actually shouldn't have written this probably -- I want to make sure that
GetActiveEntry() change is right before this lands.

[Johnny(Jianning) Ding, 2013-08-20 18:42:18]

On 2013/08/20 18:34:11, Peter Kasting wrote:
> On 2013/08/20 18:33:15, Peter Kasting wrote:
> > LGTM
> 
> I actually shouldn't have written this probably -- I want to make sure that
> GetActiveEntry() change is right before this lands.

I have no idea why this change is showed on my patch. I will upload a new
version to clean up this.

[Johnny(Jianning) Ding, 2013-08-20 20:11:36]

all done

https://codereview.chromium.org/23200006/diff/6001/content/public/common/cont...
File content/public/common/context_menu_params.h (right):

https://codereview.chromium.org/23200006/diff/6001/content/public/common/cont...
content/public/common/context_menu_params.h:77: // contents.
On 2013/08/20 18:33:16, Peter Kasting wrote:
> Nit: non-empty contents?

Done.

[Peter Kasting, 2013-08-20 20:12:46]

LGTM

[Johnny(Jianning) Ding, 2013-08-20 20:17:14]

On 2013/08/20 20:12:46, Peter Kasting wrote:
> LGTM

@jam, would you please take an owner review?

[Johnny(Jianning) Ding, 2013-08-22 20:38:15]

Seems John is out of office.

@ski, would you please take a look at chrome/*?
@avi, would you please take a look at content/*?

Thanks.

[sky, 2013-08-22 20:43:35]

LGTM

[Avi (use Gerrit), 2013-08-22 20:44:46]

LGTM

[commit-bot: I haz the power, 2013-08-22 21:10:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jnd@chromium.org/23200006/18001

[commit-bot: I haz the power, 2013-08-22 21:32:48]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[Johnny(Jianning) Ding, 2013-08-23 00:27:50]

@Chris, please take a look at content/common/view_messages.h.

Thanks!

[Johnny(Jianning) Ding, 2013-08-23 19:52:01]

On 2013/08/23 00:27:50, Johnny(Jianning) Ding wrote:
> @Chris, please take a look at content/common/view_messages.h.
> 
> Thanks!

@Cris, would you please take a look at content/common/view_messages.h for the
security review?

[Cris Neckar, 2013-08-23 20:05:05]

IPC message changes LGTM

[commit-bot: I haz the power, 2013-08-23 20:24:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jnd@chromium.org/23200006/18001

[commit-bot: I haz the power, 2013-08-23 23:00:39]

Change committed as 219376