chrome/browser/tab_contents/render_view_context_menu.cc - Issue 23200006: Don't show the search-by-image menu item when the image is blocked (no image pixel data)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/tab_contents/render_view_context_menu.cc

Issue 23200006: Don't show the search-by-image menu item when the image is blocked (no image pixel data) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/renderer_host/chrome_render_view_host_observer.cc ('k') | chrome/browser/translate/translate_manager_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/tab_contents/render_view_context_menu.cc

===================================================================

--- chrome/browser/tab_contents/render_view_context_menu.cc (revision 218524)

+++ chrome/browser/tab_contents/render_view_context_menu.cc (working copy)

@@ -865,7 +865,8 @@

const TemplateURL* const default_provider =

TemplateURLServiceFactory::GetForProfile(profile_)->

GetDefaultSearchProvider();

- if (default_provider && !default_provider->image_url().empty() &&

+ if (params_.has_image_contents && default_provider &&

+ !default_provider->image_url().empty() &&

default_provider->image_url_ref().IsValid()) {

menu_model_.AddItem(

IDC_CONTENT_CONTEXT_SEARCHWEBFORIMAGE,

@@ -1288,7 +1289,7 @@

(params_.src_url.scheme() != chrome::kChromeUIScheme);

case IDC_CONTENT_CONTEXT_COPYIMAGE:

- return !params_.is_image_blocked;

+ return params_.has_image_contents;

// Media control commands should all be disabled if the player is in an

// error state.