Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 23190045: Switch ObserverList::size() to ObserverList::might_have_observers() Pt.1 (Closed)

Created:
7 years, 4 months ago by Cait (Slow)
Modified:
7 years, 3 months ago
CC:
chromium-reviews, asanka, sadrul, nkostylev+watch_chromium.org, dcheng, sievers+watch_chromium.org, stevenjb+watch_chromium.org, tim+watch_chromium.org, jbauman+watch_chromium.org, cbentzel+watch_chromium.org, ben+watch_chromium.org, benjhayden+dwatch_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, jennb, haitaol+watch_chromium.org, gspencer+watch_chromium.org, gauravsh+watch_chromium.org, jianli, feature-media-reviews_chromium.org, oshima+watch_chromium.org, piman+watch_chromium.org, Ian Vollick, Dmitry Titov, davemoore+watch_chromium.org, danakj+watch_chromium.org, rsimha+watch_chromium.org, mmenke
Visibility:
Public.

Description

Switch ObserverList::size() to ObserverList::might_have_observers() Pt.1 This is in preparation for making ObserverList::size() protected (see bug for details). BUG=278526 TEST=no change TBR=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=219580

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Pure merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -33 lines) Patch
M ash/launcher/launcher_button.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/network/network_icon_animation.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/cros/network_library_impl_base.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/download/download_path_reservation_tracker_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/pref_proxy_config_tracker_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/policy_service_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/status_icons/status_icon.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/panels/display_settings_provider.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/panels/panel_mouse_watcher.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chromeos/dbus/shill_client_helper.cc View 1 2 chunks +3 lines, -4 lines 0 comments Download
M chromeos/dbus/shill_manager_client_stub.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/resource_dispatcher_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/webrtc_internals.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M content/browser/notification_service_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/user_input_monitor.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/dns/mdns_client_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M sync/js/sync_js_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/compositor/layer_animator_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Cait (Slow)
Lei: PTAL -- thanks!
7 years, 4 months ago (2013-08-23 22:44:42 UTC) #1
Cait (Slow)
Avi: Can you give this a quick once-over? -- Thanks!
7 years, 4 months ago (2013-08-23 22:55:47 UTC) #2
Lei Zhang
lgtm
7 years, 4 months ago (2013-08-23 22:56:33 UTC) #3
Avi (use Gerrit)
This LGTM. It might be making us aware of latent bugs where all this code ...
7 years, 4 months ago (2013-08-24 00:01:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caitkp@chromium.org/23190045/12001
7 years, 3 months ago (2013-08-26 14:39:35 UTC) #5
commit-bot: I haz the power
7 years, 3 months ago (2013-08-26 19:15:37 UTC) #6
Message was sent while issue was closed.
Change committed as 219580

Powered by Google App Engine
This is Rietveld 408576698