ash/launcher/launcher_button.cc - Issue 23190045: Switch ObserverList::size() to ObserverList::might_have_observers() Pt.1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/launcher/launcher_button.cc

Issue 23190045: Switch ObserverList::size() to ObserverList::might_have_observers() Pt.1 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Pure merge Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ash/launcher/launcher_button.cc

diff --git a/ash/launcher/launcher_button.cc b/ash/launcher/launcher_button.cc

index 26677aef06a7e55ea6ef5594d606a1eb4302d70d..7529f6f8f97683b638a4a610551793d1341fc471 100644

--- a/ash/launcher/launcher_button.cc

+++ b/ash/launcher/launcher_button.cc

@@ -67,7 +67,7 @@ class LauncherButtonAnimation : public ui::AnimationDelegate {

void RemoveObserver(Observer* observer) {

observers_.RemoveObserver(observer);

- if (observers_.size() == 0)

+ if (!observers_.might_have_observers())

animation_.Stop();

}

« no previous file with comments | « no previous file | ash/system/chromeos/network/network_icon_animation.cc » ('j') | no next file with comments »