sync/js/sync_js_controller.cc - Issue 23190045: Switch ObserverList::size() to ObserverList::might_have_observers() Pt.1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/js/sync_js_controller.cc

Issue 23190045: Switch ObserverList::size() to ObserverList::might_have_observers() Pt.1 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Pure merge Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sync/js/sync_js_controller.cc

diff --git a/sync/js/sync_js_controller.cc b/sync/js/sync_js_controller.cc

index 49f3cc79e6d9a20da350719ceac6fe719f58ddd4..4d3148fdd03581226b0b73ab302e0f6fc3d737e5 100644

--- a/sync/js/sync_js_controller.cc

+++ b/sync/js/sync_js_controller.cc

@@ -73,7 +73,7 @@ void SyncJsController::UpdateBackendEventHandler() {

// event handler we pass to it if we don't have any event

// handlers.

WeakHandle<JsEventHandler> backend_event_handler =

- (js_event_handlers_.size() > 0) ?

+ js_event_handlers_.might_have_observers() ?

MakeWeakHandle(AsWeakPtr()) : WeakHandle<SyncJsController>();

js_backend_.Call(FROM_HERE, &JsBackend::SetJsEventHandler,

backend_event_handler);

« no previous file with comments | « net/dns/mdns_client_impl.cc ('k') | ui/compositor/layer_animator_unittest.cc » ('j') | no next file with comments »