Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 23108007: Add width and height to chrome.tabs.Tab. (Closed)

Created:
7 years, 4 months ago by haibinlu
Modified:
7 years, 4 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add width and height to chrome.tabs.Tab. This allows extension to properly resize the tab to the right aspect ratio. BUG=224352 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=218033

Patch Set 1 #

Patch Set 2 : added unit tests #

Patch Set 3 : Code formatting. Check width and height is positive for newly created tab. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -2 lines) Patch
M chrome/browser/extensions/extension_tab_util.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_tabs_apitest.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/tabs.json View 1 chunk +3 lines, -1 line 0 comments Download
A + chrome/test/data/extensions/api_test/tabs/basics/tab_size.html View 1 1 chunk +2 lines, -1 line 0 comments Download
A chrome/test/data/extensions/api_test/tabs/basics/tab_size.js View 1 2 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
haibinlu
7 years, 4 months ago (2013-08-14 21:18:11 UTC) #1
not at google - send to devlin
lgtm
7 years, 4 months ago (2013-08-14 23:01:13 UTC) #2
justinlin
looks good. as discussed, please add test and file bug for the size update delay.
7 years, 4 months ago (2013-08-15 00:22:52 UTC) #3
justinlin
lgtm
7 years, 4 months ago (2013-08-15 05:50:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haibinlu@chromium.org/23108007/9001
7 years, 4 months ago (2013-08-15 17:18:22 UTC) #5
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) telemetry_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=160347
7 years, 4 months ago (2013-08-15 18:21:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haibinlu@chromium.org/23108007/9001
7 years, 4 months ago (2013-08-15 18:24:30 UTC) #7
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) telemetry_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=160408
7 years, 4 months ago (2013-08-15 19:13:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haibinlu@chromium.org/23108007/9001
7 years, 4 months ago (2013-08-16 17:02:02 UTC) #9
commit-bot: I haz the power
7 years, 4 months ago (2013-08-16 17:23:38 UTC) #10
Message was sent while issue was closed.
Change committed as 218033

Powered by Google App Engine
This is Rietveld 408576698