Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(842)

Side by Side Diff: chrome/browser/extensions/extension_tabs_apitest.cc

Issue 23108007: Add width and height to chrome.tabs.Tab. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Code formatting. Check width and height is positive for newly created tab. Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/extensions/extension_tab_util.cc ('k') | chrome/common/extensions/api/tabs.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/extension_apitest.h" 5 #include "chrome/browser/extensions/extension_apitest.h"
6 6
7 #include "base/prefs/pref_service.h" 7 #include "base/prefs/pref_service.h"
8 #include "chrome/browser/prefs/incognito_mode_prefs.h" 8 #include "chrome/browser/prefs/incognito_mode_prefs.h"
9 #include "chrome/browser/profiles/profile.h" 9 #include "chrome/browser/profiles/profile.h"
10 #include "chrome/browser/ui/browser.h" 10 #include "chrome/browser/ui/browser.h"
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
71 #endif 71 #endif
72 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, MAYBE_Tabs2) { 72 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, MAYBE_Tabs2) {
73 ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "crud2.html")) << message_; 73 ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "crud2.html")) << message_;
74 } 74 }
75 75
76 // crbug.com/149924 76 // crbug.com/149924
77 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, DISABLED_TabDuplicate) { 77 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, DISABLED_TabDuplicate) {
78 ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "duplicate.html")) << message_; 78 ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "duplicate.html")) << message_;
79 } 79 }
80 80
81 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, TabSize) {
82 ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "tab_size.html")) << message_;
83 }
84
81 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, TabUpdate) { 85 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, TabUpdate) {
82 ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "update.html")) << message_; 86 ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "update.html")) << message_;
83 } 87 }
84 88
85 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, TabPinned) { 89 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, TabPinned) {
86 ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "pinned.html")) << message_; 90 ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "pinned.html")) << message_;
87 } 91 }
88 92
89 // Flaky on windows: http://crbug.com/238667 93 // Flaky on windows: http://crbug.com/238667
90 #if defined(OS_WIN) 94 #if defined(OS_WIN)
(...skipping 148 matching lines...) Expand 10 before | Expand all | Expand 10 after
239 << message_; 243 << message_;
240 } 244 }
241 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, DISABLED_GetViewsOfCreatedWindow) { 245 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, DISABLED_GetViewsOfCreatedWindow) {
242 ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "get_views_window.html")) 246 ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "get_views_window.html"))
243 << message_; 247 << message_;
244 } 248 }
245 249
246 // Adding a new test? Awesome. But API tests are the old hotness. The 250 // Adding a new test? Awesome. But API tests are the old hotness. The
247 // new hotness is extension_test_utils. See tabs_test.cc for an example. 251 // new hotness is extension_test_utils. See tabs_test.cc for an example.
248 // We are trying to phase out many uses of API tests as they tend to be flaky. 252 // We are trying to phase out many uses of API tests as they tend to be flaky.
OLDNEW
« no previous file with comments | « chrome/browser/extensions/extension_tab_util.cc ('k') | chrome/common/extensions/api/tabs.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698