chrome/common/extensions/api/tabs.json - Issue 23108007: Add width and height to chrome.tabs.Tab.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/tabs.json

Issue 23108007: Add width and height to chrome.tabs.Tab. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Code formatting. Check width and height is positive for newly created tab. Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_tabs_apitest.cc ('k') | chrome/test/data/extensions/api_test/tabs/basics/tab_size.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/tabs.json

diff --git a/chrome/common/extensions/api/tabs.json b/chrome/common/extensions/api/tabs.json

index c18f5c45cac9db29cc551d4e264ffc365a4d5164..bdfe2a198354b75488444e2d8592d0c0668018d2 100644

--- a/chrome/common/extensions/api/tabs.json

+++ b/chrome/common/extensions/api/tabs.json

@@ -24,7 +24,9 @@

"title": {"type": "string", "optional": true, "optional": true, "description": "The title of the tab. This will only be present if the extension has the 'tabs' or 'webNavigation' permission. It may also be an empty string if the tab is loading."},

"favIconUrl": {"type": "string", "optional": true, "optional": true, "description": "The URL of the tab's favicon. This will only be present if the extension has the 'tabs' or 'webNavigation' permission. It may also be an empty string if the tab is loading."},

"status": {"type": "string", "optional": true, "description": "Either <em>loading</em> or <em>complete</em>."},

- "incognito": {"type": "boolean", "description": "Whether the tab is in an incognito window."}

+ "incognito": {"type": "boolean", "description": "Whether the tab is in an incognito window."},

+ "width": {"type": "integer", "optional": true, "description": "The width of the tab in pixels."},

+ "height": {"type": "integer", "optional": true, "description": "The height of the tab in pixels."}

}

{