Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(850)

Unified Diff: lib/polymer_element.dart

Issue 23095010: Fixed warning causing drone.io to fail (Closed) Base URL: https://github.com/dart-lang/web-ui.git@master
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/polymer_element.dart
diff --git a/lib/polymer_element.dart b/lib/polymer_element.dart
index 76259d64692d420acc81a6d649c7721a83f425d5..ef9094e6e8a0e35cfb0be32a81009a27a8cdfe21 100644
--- a/lib/polymer_element.dart
+++ b/lib/polymer_element.dart
@@ -174,7 +174,7 @@ class PolymerElement extends CustomElement with _EventsMixin {
* Using Polymer's platform/src/ShadowCSS.js passing the style tag's content.
*/
void _shimCss(ShadowRoot root, String localName, String extendsName) {
- var platform = js.context.Platform;
+ var platform = (js.context as dynamic).Platform;
Jennifer Messerly 2013/08/16 17:47:27 eek, this is ugly! can you add a TODO and refer to
terry 2013/08/16 17:55:34 Do you think another solution is to change the sig
Jennifer Messerly 2013/08/16 17:58:32 in this case, yes. but it doesn't help with the ge
Siggi Cherem (dart-lang) 2013/08/16 18:13:06 I believe you can also fix this by using this nota
Jennifer Messerly 2013/08/16 18:17:56 Yeah, the strange thing about that though is we ar
terry 2013/08/16 19:02:05 Done. My larger question is the TODO should go in
if (platform == null) return;
var shadowCss = platform.ShadowCSS;
if (shadowCss == null) return;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698