Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Side by Side Diff: lib/polymer_element.dart

Issue 23095010: Fixed warning causing drone.io to fail (Closed) Base URL: https://github.com/dart-lang/web-ui.git@master
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library polymer.polymer_element; 5 library polymer.polymer_element;
6 6
7 import 'dart:async'; 7 import 'dart:async';
8 import 'dart:html'; 8 import 'dart:html';
9 import 'dart:mirrors'; 9 import 'dart:mirrors';
10 10
(...skipping 156 matching lines...) Expand 10 before | Expand all | Expand 10 after
167 if (propObserver != null) { 167 if (propObserver != null) {
168 return new _PolymerBinding(this, name, model, path, propObserver); 168 return new _PolymerBinding(this, name, model, path, propObserver);
169 } 169 }
170 return super.createBinding(name, model, path); 170 return super.createBinding(name, model, path);
171 } 171 }
172 172
173 /** 173 /**
174 * Using Polymer's platform/src/ShadowCSS.js passing the style tag's content. 174 * Using Polymer's platform/src/ShadowCSS.js passing the style tag's content.
175 */ 175 */
176 void _shimCss(ShadowRoot root, String localName, String extendsName) { 176 void _shimCss(ShadowRoot root, String localName, String extendsName) {
177 var platform = js.context.Platform; 177 var platform = (js.context as dynamic).Platform;
Jennifer Messerly 2013/08/16 17:47:27 eek, this is ugly! can you add a TODO and refer to
terry 2013/08/16 17:55:34 Do you think another solution is to change the sig
Jennifer Messerly 2013/08/16 17:58:32 in this case, yes. but it doesn't help with the ge
Siggi Cherem (dart-lang) 2013/08/16 18:13:06 I believe you can also fix this by using this nota
Jennifer Messerly 2013/08/16 18:17:56 Yeah, the strange thing about that though is we ar
terry 2013/08/16 19:02:05 Done. My larger question is the TODO should go in
178 if (platform == null) return; 178 if (platform == null) return;
179 var shadowCss = platform.ShadowCSS; 179 var shadowCss = platform.ShadowCSS;
180 if (shadowCss == null) return; 180 if (shadowCss == null) return;
181 181
182 // TODO(terry): Remove calls to shimShadowDOMStyling2 and replace with 182 // TODO(terry): Remove calls to shimShadowDOMStyling2 and replace with
183 // shimShadowDOMStyling when we support unwrapping dart:html 183 // shimShadowDOMStyling when we support unwrapping dart:html
184 // Element to a JS DOM node. 184 // Element to a JS DOM node.
185 var shimShadowDOMStyling2 = shadowCss.shimShadowDOMStyling2; 185 var shimShadowDOMStyling2 = shadowCss.shimShadowDOMStyling2;
186 if (shimShadowDOMStyling2 == null) return; 186 if (shimShadowDOMStyling2 == null) return;
187 var style = root.query('style'); 187 var style = root.query('style');
(...skipping 355 matching lines...) Expand 10 before | Expand all | Expand 10 after
543 'onKeyMessage': MediaElement.keyMessageEvent, 543 'onKeyMessage': MediaElement.keyMessageEvent,
544 'onNeedKey': MediaElement.needKeyEvent, 544 'onNeedKey': MediaElement.needKeyEvent,
545 'onWebGlContextLost': CanvasElement.webGlContextLostEvent, 545 'onWebGlContextLost': CanvasElement.webGlContextLostEvent,
546 'onWebGlContextRestored': CanvasElement.webGlContextRestoredEvent, 546 'onWebGlContextRestored': CanvasElement.webGlContextRestoredEvent,
547 'onPointerLockChange': Document.pointerLockChangeEvent, 547 'onPointerLockChange': Document.pointerLockChangeEvent,
548 'onPointerLockError': Document.pointerLockErrorEvent, 548 'onPointerLockError': Document.pointerLockErrorEvent,
549 'onReadyStateChange': Document.readyStateChangeEvent, 549 'onReadyStateChange': Document.readyStateChangeEvent,
550 'onSelectionChange': Document.selectionChangeEvent, 550 'onSelectionChange': Document.selectionChangeEvent,
551 'onSecurityPolicyViolation': Document.securityPolicyViolationEvent, 551 'onSecurityPolicyViolation': Document.securityPolicyViolationEvent,
552 }; 552 };
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698