Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(725)

Issue 23095010: Fixed warning causing drone.io to fail (Closed)

Created:
7 years, 4 months ago by terry
Modified:
7 years, 4 months ago
CC:
reviews_dartlang.org, web-ui-dev+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/web-ui.git@master
Visibility:
Public.

Description

Fixed warning causing drone.io to fail BUG=

Patch Set 1 #

Total comments: 6

Patch Set 2 : Temporary workaround w/ TODO to remove" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M lib/polymer_element.dart View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
terry
7 years, 4 months ago (2013-08-16 17:37:01 UTC) #1
Jennifer Messerly
https://chromiumcodereview.appspot.com/23095010/diff/1/lib/polymer_element.dart File lib/polymer_element.dart (right): https://chromiumcodereview.appspot.com/23095010/diff/1/lib/polymer_element.dart#newcode177 lib/polymer_element.dart:177: var platform = (js.context as dynamic).Platform; eek, this is ...
7 years, 4 months ago (2013-08-16 17:47:27 UTC) #2
terry
https://chromiumcodereview.appspot.com/23095010/diff/1/lib/polymer_element.dart File lib/polymer_element.dart (right): https://chromiumcodereview.appspot.com/23095010/diff/1/lib/polymer_element.dart#newcode177 lib/polymer_element.dart:177: var platform = (js.context as dynamic).Platform; Do you think ...
7 years, 4 months ago (2013-08-16 17:55:34 UTC) #3
Jennifer Messerly
https://chromiumcodereview.appspot.com/23095010/diff/1/lib/polymer_element.dart File lib/polymer_element.dart (right): https://chromiumcodereview.appspot.com/23095010/diff/1/lib/polymer_element.dart#newcode177 lib/polymer_element.dart:177: var platform = (js.context as dynamic).Platform; On 2013/08/16 17:55:34, ...
7 years, 4 months ago (2013-08-16 17:58:32 UTC) #4
Siggi Cherem (dart-lang)
https://chromiumcodereview.appspot.com/23095010/diff/1/lib/polymer_element.dart File lib/polymer_element.dart (right): https://chromiumcodereview.appspot.com/23095010/diff/1/lib/polymer_element.dart#newcode177 lib/polymer_element.dart:177: var platform = (js.context as dynamic).Platform; On 2013/08/16 17:58:32, ...
7 years, 4 months ago (2013-08-16 18:13:06 UTC) #5
Jennifer Messerly
https://chromiumcodereview.appspot.com/23095010/diff/1/lib/polymer_element.dart File lib/polymer_element.dart (right): https://chromiumcodereview.appspot.com/23095010/diff/1/lib/polymer_element.dart#newcode177 lib/polymer_element.dart:177: var platform = (js.context as dynamic).Platform; On 2013/08/16 18:13:06, ...
7 years, 4 months ago (2013-08-16 18:17:56 UTC) #6
terry
7 years, 4 months ago (2013-08-16 19:02:05 UTC) #7
Added TODO

https://chromiumcodereview.appspot.com/23095010/diff/1/lib/polymer_element.dart
File lib/polymer_element.dart (right):

https://chromiumcodereview.appspot.com/23095010/diff/1/lib/polymer_element.da...
lib/polymer_element.dart:177: var platform = (js.context as dynamic).Platform;
Done.

My larger question is the TODO should go in js.dart with a temporary fix for the
context getter.  Then all downstream users of js interop aren't hitting this
ugliness.

On 2013/08/16 17:58:32, John Messerly wrote:
> On 2013/08/16 17:55:34, terry wrote:
> > Do you think another solution is to change the signature of js.dart context
> > getter from
> > 
> > Proxy get context
> > 
> > to
> > 
> > get context
> > 
> > So it's untyped?  Wouldn't that solve this particular problem.
> > 
> > On 2013/08/16 17:47:27, John Messerly wrote:
> > > eek, this is ugly!
> > > can you add a TODO and refer to this bug:
> > > https://code.google.com/p/dart/issues/detail?id=6111
> > >  
> > 
> 
> in this case, yes. but it doesn't help with the general problem

Powered by Google App Engine
This is Rietveld 408576698