Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 229723002: Better error reasons for rAc (Closed)

Created:
6 years, 8 months ago by Evan Stade
Modified:
6 years, 8 months ago
CC:
chromium-reviews, benquan, jam, browser-components-watch_chromium.org, darin-cc_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Visibility:
Public.

Description

Better error reasons for rAc this addresses the first half of the linked bug (improved error reason when rAc fails) BUG=361216 TBR=aruslan@chromium.org, michaelbai@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263345

Patch Set 1 #

Total comments: 2

Patch Set 2 : copy enum #

Patch Set 3 : FIXME #

Total comments: 9

Patch Set 4 : 2 nits #

Patch Set 5 : absolute #

Patch Set 6 : woopsies #

Total comments: 8

Patch Set 7 : fix test #

Patch Set 8 : mac fix #

Patch Set 9 : android #

Patch Set 10 : android #

Patch Set 11 : android #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -73 lines) Patch
M android_webview/native/aw_autofill_manager_delegate.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -1 line 0 comments Download
M android_webview/native/aw_autofill_manager_delegate.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/android/autofill/autofill_dialog_controller_android.h View 1 2 3 4 5 6 7 8 9 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/android/autofill/autofill_dialog_controller_android.cc View 1 2 3 4 5 6 7 8 6 chunks +9 lines, -6 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc View 1 5 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller_impl.h View 1 2 3 4 5 6 4 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc View 1 2 3 4 5 6 6 chunks +8 lines, -6 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc View 1 2 3 4 5 6 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/autofill/tab_autofill_manager_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc View 1 2 3 4 5 6 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa_browsertest.mm View 1 2 3 4 5 6 7 1 chunk +2 lines, -1 line 0 comments Download
M components/autofill/content/browser/request_autocomplete_manager.h View 1 2 5 2 chunks +6 lines, -12 lines 0 comments Download
M components/autofill/content/browser/request_autocomplete_manager.cc View 1 2 3 5 4 chunks +34 lines, -19 lines 0 comments Download
M components/autofill/content/browser/request_autocomplete_manager_unittest.cc View 1 2 3 4 5 6 3 chunks +9 lines, -6 lines 0 comments Download
M components/autofill/core/browser/autofill_manager_delegate.h View 1 5 2 chunks +14 lines, -1 line 0 comments Download
M components/autofill/core/browser/autofill_manager_unittest.cc View 1 2 3 5 2 chunks +5 lines, -3 lines 0 comments Download
M components/autofill/core/browser/test_autofill_manager_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/test_autofill_manager_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 37 (0 generated)
Evan Stade
not ready for full review yet, just running by the trybots + a quick question ...
6 years, 8 months ago (2014-04-08 23:38:52 UTC) #1
blundell
Thanks for raising this question. https://codereview.chromium.org/229723002/diff/1/components/autofill/core/browser/DEPS File components/autofill/core/browser/DEPS (right): https://codereview.chromium.org/229723002/diff/1/components/autofill/core/browser/DEPS#newcode11 components/autofill/core/browser/DEPS:11: "+third_party/WebKit/public/web", It's not OK, ...
6 years, 8 months ago (2014-04-09 09:09:46 UTC) #2
Evan Stade
OK, please review. dbeam - everything blundell - components/autofill/ The meaty changes in content are ...
6 years, 8 months ago (2014-04-09 22:11:15 UTC) #3
Evan Stade
> The meaty changes in content are in autofill_manager_delegate.h and > request_autocomplete_manager.*. s/content/components
6 years, 8 months ago (2014-04-09 22:11:37 UTC) #4
Dan Beam
are you also working in the blink changes? https://codereview.chromium.org/229723002/diff/40001/components/autofill/content/browser/request_autocomplete_manager.cc File components/autofill/content/browser/request_autocomplete_manager.cc (right): https://codereview.chromium.org/229723002/diff/40001/components/autofill/content/browser/request_autocomplete_manager.cc#newcode57 components/autofill/content/browser/request_autocomplete_manager.cc:57: AutofillManagerDelegate::ResultCallback ...
6 years, 8 months ago (2014-04-09 22:16:54 UTC) #5
Evan Stade
https://codereview.chromium.org/229723002/diff/40001/components/autofill/content/browser/request_autocomplete_manager.cc File components/autofill/content/browser/request_autocomplete_manager.cc (right): https://codereview.chromium.org/229723002/diff/40001/components/autofill/content/browser/request_autocomplete_manager.cc#newcode57 components/autofill/content/browser/request_autocomplete_manager.cc:57: AutofillManagerDelegate::ResultCallback callback = On 2014/04/09 22:16:54, Dan Beam wrote: ...
6 years, 8 months ago (2014-04-09 22:37:41 UTC) #6
Ilya Sherman
https://codereview.chromium.org/229723002/diff/40001/components/autofill/core/browser/autofill_manager_delegate.h File components/autofill/core/browser/autofill_manager_delegate.h (right): https://codereview.chromium.org/229723002/diff/40001/components/autofill/core/browser/autofill_manager_delegate.h#newcode46 components/autofill/core/browser/autofill_manager_delegate.h:46: // Copy of blink::WebFormElement::AutocompleteResult. On 2014/04/09 22:37:42, Evan Stade ...
6 years, 8 months ago (2014-04-09 22:39:33 UTC) #7
Evan Stade
On 2014/04/09 22:39:33, Ilya Sherman wrote: > https://codereview.chromium.org/229723002/diff/40001/components/autofill/core/browser/autofill_manager_delegate.h > File components/autofill/core/browser/autofill_manager_delegate.h (right): > > https://codereview.chromium.org/229723002/diff/40001/components/autofill/core/browser/autofill_manager_delegate.h#newcode46 ...
6 years, 8 months ago (2014-04-09 23:15:22 UTC) #8
Dan Beam
lgtm
6 years, 8 months ago (2014-04-09 23:15:59 UTC) #9
Dan Beam
https://chromiumcodereview.appspot.com/229723002/diff/90001/components/autofill/core/browser/autofill_manager_delegate.h File components/autofill/core/browser/autofill_manager_delegate.h (right): https://chromiumcodereview.appspot.com/229723002/diff/90001/components/autofill/core/browser/autofill_manager_delegate.h#newcode53 components/autofill/core/browser/autofill_manager_delegate.h:53: AutocompleteResultErrorUnsupported, ah, here's where you got/agreed on this: https://www.w3.org/Bugs/Public/show_bug.cgi?id=22701#c4
6 years, 8 months ago (2014-04-09 23:20:04 UTC) #10
Dan Beam
https://chromiumcodereview.appspot.com/229723002/diff/90001/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc File chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc (right): https://chromiumcodereview.appspot.com/229723002/diff/90001/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc#newcode658 chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc:658: NULL); actually, can you add a unit test for ...
6 years, 8 months ago (2014-04-09 23:21:47 UTC) #11
Evan Stade
https://chromiumcodereview.appspot.com/229723002/diff/90001/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc File chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc (right): https://chromiumcodereview.appspot.com/229723002/diff/90001/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc#newcode658 chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc:658: NULL); On 2014/04/09 23:21:47, Dan Beam wrote: > actually, ...
6 years, 8 months ago (2014-04-10 00:59:36 UTC) #12
blundell
//components LGTM There's no way for the iOS port and //third_party/WebKit to share type definitions ...
6 years, 8 months ago (2014-04-10 08:03:40 UTC) #13
Evan Stade
https://codereview.chromium.org/229723002/diff/90001/components/autofill/core/browser/autofill_manager_delegate.h File components/autofill/core/browser/autofill_manager_delegate.h (right): https://codereview.chromium.org/229723002/diff/90001/components/autofill/core/browser/autofill_manager_delegate.h#newcode46 components/autofill/core/browser/autofill_manager_delegate.h:46: // Copy of blink::WebFormElement::AutocompleteResult. On 2014/04/10 08:03:40, blundell wrote: ...
6 years, 8 months ago (2014-04-10 16:38:57 UTC) #14
Evan Stade
The CQ bit was checked by estade@chromium.org
6 years, 8 months ago (2014-04-10 16:54:48 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/229723002/110001
6 years, 8 months ago (2014-04-10 16:54:59 UTC) #16
Dan Beam
https://codereview.chromium.org/229723002/diff/90001/components/autofill/core/browser/autofill_manager_delegate.h File components/autofill/core/browser/autofill_manager_delegate.h (right): https://codereview.chromium.org/229723002/diff/90001/components/autofill/core/browser/autofill_manager_delegate.h#newcode46 components/autofill/core/browser/autofill_manager_delegate.h:46: // Copy of blink::WebFormElement::AutocompleteResult. On 2014/04/10 16:38:58, Evan Stade ...
6 years, 8 months ago (2014-04-10 17:06:15 UTC) #17
Dan Beam
slgtm (sorry if this messes up your CQ)
6 years, 8 months ago (2014-04-10 17:06:28 UTC) #18
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-10 18:21:59 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on mac_chromium_compile_dbg
6 years, 8 months ago (2014-04-10 18:22:00 UTC) #20
Evan Stade
The CQ bit was checked by estade@chromium.org
6 years, 8 months ago (2014-04-10 19:53:29 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/229723002/130001
6 years, 8 months ago (2014-04-10 19:54:12 UTC) #22
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-10 20:28:20 UTC) #23
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=60724
6 years, 8 months ago (2014-04-10 20:28:20 UTC) #24
Evan Stade
+groby for mac, aruslan for android
6 years, 8 months ago (2014-04-10 21:15:58 UTC) #25
aruslan1
android lgtm -- thanks!
6 years, 8 months ago (2014-04-10 21:20:28 UTC) #26
groby-ooo-7-16
cocoa LGTM
6 years, 8 months ago (2014-04-10 21:26:54 UTC) #27
Evan Stade
The CQ bit was checked by estade@chromium.org
6 years, 8 months ago (2014-04-10 22:48:36 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/229723002/170001
6 years, 8 months ago (2014-04-10 22:48:46 UTC) #29
Evan Stade
The CQ bit was checked by estade@chromium.org
6 years, 8 months ago (2014-04-11 18:53:56 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/229723002/190001
6 years, 8 months ago (2014-04-11 18:56:31 UTC) #31
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-11 19:33:10 UTC) #32
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=61001
6 years, 8 months ago (2014-04-11 19:33:11 UTC) #33
Evan Stade
TBR=aruslan@chromium.org, michaelbai@chromium.org for android and android_webview, respectively (not sure why CQ isn't picking up aruslan's ...
6 years, 8 months ago (2014-04-11 19:39:27 UTC) #34
Evan Stade
The CQ bit was checked by estade@chromium.org
6 years, 8 months ago (2014-04-11 19:39:33 UTC) #35
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/229723002/190001
6 years, 8 months ago (2014-04-11 19:40:14 UTC) #36
commit-bot: I haz the power
6 years, 8 months ago (2014-04-11 20:45:32 UTC) #37
Message was sent while issue was closed. 
Change committed as 263345

Powered by Google App Engine
This is Rietveld 408576698