Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: chrome/browser/ui/android/autofill/autofill_dialog_controller_android.cc

Issue 229723002: Better error reasons for rAc (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: android Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/android/autofill/autofill_dialog_controller_android.cc
diff --git a/chrome/browser/ui/android/autofill/autofill_dialog_controller_android.cc b/chrome/browser/ui/android/autofill/autofill_dialog_controller_android.cc
index 97ea58911e996f66d8f86ac96a4b3bc0a35bd0e8..0912f03591712f09fce6976ebd6e1805b6aa45be 100644
--- a/chrome/browser/ui/android/autofill/autofill_dialog_controller_android.cc
+++ b/chrome/browser/ui/android/autofill/autofill_dialog_controller_android.cc
@@ -142,7 +142,7 @@ base::WeakPtr<AutofillDialogController> AutofillDialogControllerAndroid::Create(
content::WebContents* contents,
const FormData& form_structure,
const GURL& source_url,
- const base::Callback<void(const FormStructure*)>& callback) {
+ const AutofillManagerDelegate::ResultCallback& callback) {
// AutofillDialogControllerAndroid owns itself.
AutofillDialogControllerAndroid* autofill_dialog_controller =
new AutofillDialogControllerAndroid(contents,
@@ -159,7 +159,7 @@ AutofillDialogController::Create(
content::WebContents* contents,
const FormData& form_structure,
const GURL& source_url,
- const base::Callback<void(const FormStructure*)>& callback) {
+ const AutofillManagerDelegate::ResultCallback& callback) {
return AutofillDialogControllerAndroid::Create(contents,
form_structure,
source_url,
@@ -206,7 +206,8 @@ void AutofillDialogControllerAndroid::Show() {
!Java_AutofillDialogControllerAndroid_isDialogAllowed(
env,
invoked_from_same_origin_)) {
- callback_.Run(NULL);
+ callback_.Run(AutofillManagerDelegate::AutocompleteResultErrorUnsupported,
+ NULL);
delete this;
return;
}
@@ -324,7 +325,8 @@ bool AutofillDialogControllerAndroid::
void AutofillDialogControllerAndroid::DialogCancel(JNIEnv* env,
jobject obj) {
LogOnCancelMetrics();
- callback_.Run(NULL);
+ callback_.Run(AutofillManagerDelegate::AutocompleteResultErrorCancel,
+ NULL);
}
void AutofillDialogControllerAndroid::DialogContinue(
@@ -380,7 +382,8 @@ void AutofillDialogControllerAndroid::DialogContinue(
LogOnFinishSubmitMetrics();
// Callback should be called as late as possible.
- callback_.Run(&form_structure_);
+ callback_.Run(AutofillManagerDelegate::AutocompleteResultSuccess,
+ &form_structure_);
// This might delete us.
Hide();
@@ -390,7 +393,7 @@ AutofillDialogControllerAndroid::AutofillDialogControllerAndroid(
content::WebContents* contents,
const FormData& form_structure,
const GURL& source_url,
- const base::Callback<void(const FormStructure*)>& callback)
+ const AutofillManagerDelegate::ResultCallback& callback)
: profile_(Profile::FromBrowserContext(contents->GetBrowserContext())),
contents_(contents),
initial_user_state_(AutofillMetrics::DIALOG_USER_STATE_UNKNOWN),

Powered by Google App Engine
This is Rietveld 408576698